Rollup of 5 pull requests#159556
Conversation
…is is the same behaviour as `posix_fallocate`. And add tests for `fallocate` based on `posix_fallocate`.
Support `fallocate` on Linux
To match the deadlocked diagnostic in both tests, we will need to call the `libc::read/write()` methods directly.
Use shared libc helpers in tests
memcmp: add tests and update comments
This updates the rust-version file to 48c2cee.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@48c2cee Filtered ref: rust-lang/miri@acbeeb6 Upstream diff: rust-lang/rust@be8e824...48c2cee This merge was created using https://github.com/rust-lang/josh-sync.
…r extra indirection
FileDescription: make destroy a NOP by default and document the risks
This updates the rust-version file to 55b6bd8.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@55b6bd8 Filtered ref: rust-lang/miri@2631f42 Upstream diff: rust-lang/rust@48c2cee...55b6bd8 This merge was created using https://github.com/rust-lang/josh-sync.
Automatic Rustup
remove bogus sanity check from weak memory mixed-size logic
Dropped readiness watchers are now removed from the global readiness interest table when the GC runs.
move scheduler into its own file
Lazily destroy readiness watchers
This updates the rust-version file to 38a0576.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@38a0576 Filtered ref: rust-lang/miri@b83abd8 Upstream diff: rust-lang/rust@55b6bd8...38a0576 This merge was created using https://github.com/rust-lang/josh-sync.
Of late I've been looking at layout a bunch, which means staring at things like
```rust
backend_repr: ScalarPair {
a: Initialized {
value: Int(
I8,
false,
),
valid_range: 0..=1,
},
b: Union {
value: Int(
I8,
false,
),
},
b_offset: Size(1 bytes),
},
```
and that's just kinda long and unfriendly.
Thus this PR that just changes `Debug` -- nothing else! -- so for example that shows as
```rust
backend_repr: ScalarPair {
a: u8 is 0..=1,
b: union u8,
b_offset: Size(1 bytes),
},
```
…clarfonthey Move `std::io::BufRead` to `alloc::io` ACP: rust-lang/libs-team#755 Tracking issue: rust-lang#154046 Split From: rust-lang#156527 ~~Blocked On: rust-lang#158545 ## Description Moves `std::io::BufRead` to `alloc::io`. This is effectively a direct cut and paste, but with a large diff due to how many implementations need to be moved into `alloc`. Blocked on rust-lang#158545. --- ## Notes * No AI tooling of any kind was used during the creation of this PR. * Please see rust-lang#154046 (comment) for a review order and broader context for this PR.
…=jhpratt
Remove SIZE generic param from DisplayBuffer in core::net
These symbols were observed on the surface of `core.o`:
```
<core::net::display_buffer::DisplayBuffer<15> as core::fmt::Write>::write_char
<core::net::display_buffer::DisplayBuffer<15> as core::fmt::Write>::write_fmt
<core::net::display_buffer::DisplayBuffer<15> as core::fmt::Write>::write_str
<core::net::display_buffer::DisplayBuffer<21> as core::fmt::Write>::write_char
<core::net::display_buffer::DisplayBuffer<21> as core::fmt::Write>::write_fmt
<core::net::display_buffer::DisplayBuffer<21> as core::fmt::Write>::write_str
<core::net::display_buffer::DisplayBuffer<39> as core::fmt::Write>::write_char
<core::net::display_buffer::DisplayBuffer<39> as core::fmt::Write>::write_fmt
<core::net::display_buffer::DisplayBuffer<39> as core::fmt::Write>::write_str
<core::net::display_buffer::DisplayBuffer<58> as core::fmt::Write>::write_char
<core::net::display_buffer::DisplayBuffer<58> as core::fmt::Write>::write_fmt
<core::net::display_buffer::DisplayBuffer<58> as core::fmt::Write>::write_str
```
There's no reason to instantiate four different copies of this super simple logic, so remove the size parameter allowing each case to call into the same shared machine code.
It's not possible to inline these symbols into the `{SocketAddrV*,Ipv*Addr}::fmt` methods because `core::fmt::write` constructs a `&mut dyn fmt::Write` to the `DisplayBuffer`.
miri subtree update Subtree update of `miri` to rust-lang/miri@f7f708b. Created using https://github.com/rust-lang/josh-sync. r? @ghost
…p, r=mejrs Some cleanup in `rustc_attr_parsing` My hands got itchy while digging through a few modules. ...and maybe run perf? IDK r? compiler
…-debug, r=jieyouxu
[rustc_abi] Customize `Debug` for `Primitive` and `Scalar`
Of late I've been looking at layout a bunch, which means staring at things like
```rust
backend_repr: ScalarPair {
a: Initialized {
value: Int(
I8,
false,
),
valid_range: 0..=1,
},
b: Union {
value: Int(
I8,
false,
),
},
b_offset: Size(1 bytes),
},
```
and that's just kinda long and unfriendly.
Thus this PR that just changes `Debug` -- nothing else! -- so for example that shows as
```rust
backend_repr: ScalarPair {
a: u8 is 0..=1,
b: union u8,
b_offset: Size(1 bytes),
},
```
---
EDIT: oh, net -1404 lines is a pretty good summary of why 🙃
|
@bors r+ rollup=never p=5 |
This comment has been minimized.
This comment has been minimized.
|
📌 Perf builds for each rolled up PR:
previous master: c7d7da3428 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing c7d7da3 (parent) -> 234c31c (this PR) Test differencesShow 232 test diffs232 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 234c31cd674e11703f15d290cba7ff81dfe8b4b8 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (234c31c): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -0.7%, secondary 0.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis perf run didn't have relevant results for this metric. Binary sizeResults (primary 0.0%, secondary 0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 484.052s -> 488.235s (0.86%) |
Successful merges:
std::io::BufReadtoalloc::io#158546 (Movestd::io::BufReadtoalloc::io)rustc_attr_parsing#159508 (Some cleanup inrustc_attr_parsing)DebugforPrimitiveandScalar#159539 ([rustc_abi] CustomizeDebugforPrimitiveandScalar)r? @ghost
Create a similar rollup