Skip to content

chore(ci): diagnose open handles in smoketests #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrvb-rl merged 2 commits into from
Sep 21, 2026
+7 −3
Merged

chore(ci): diagnose open handles in smoketests #842

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c60a9a1
chore(ci): diagnose open handles in smoketests
jrvb-rl Sep 21, 2026
5bf59b8
chore(ci): note restoring smoketest workers after diagnosis
jrvb-rl Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/smoke-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:
required: true
type: string
discriminator:
default: "true"
default: 'true'
type: string
workflow_dispatch:
inputs:
Expand Down Expand Up @@ -79,5 +79,9 @@ jobs:
if: matrix.transport == 'http2'
run: node tests/smoketests/scripts/verify-http2.mjs

- name: Run smoke tests
run: yarn test:smoke --maxWorkers=800% --color
- name: Run smoke tests with open-handle diagnostics
# Jest reports allocation stacks for handles preventing clean shutdown.
# Detection runs serially; the job timeout bounds a leaked-handle hang.
# TODO: Restore --maxWorkers=800% and remove serial open-handle diagnostics
# once the shutdown paths have been diagnosed.
run: yarn test:smoke --runInBand --detectOpenHandles --color
Comment on lines +82 to +87

@jrvb-rl jrvb-rl Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a TODO to remind us to bump up workers again once we've diagnosed the shutdown paths.

@jrvb-rl jrvb-rl Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a TODO beside the diagnostic command to restore --maxWorkers=800% and remove serial open-handle diagnostics once the shutdown paths have been diagnosed.

Loading