chore(ci): diagnose open handles in smoketests - #842
Merged
Merged
Conversation
|
✅ Reflex agent status: Completed
This PR was created by Reflex. This comment updates in place as agents work. |
jrvb-rl
commented
Sep 21, 2026
Comment on lines
+82
to
+85
| - name: Run smoke tests with open-handle diagnostics | ||
| # Jest reports allocation stacks for handles preventing clean shutdown. | ||
| # Detection runs serially; the job timeout bounds a leaked-handle hang. | ||
| run: yarn test:smoke --runInBand --detectOpenHandles --color |
Contributor
Author
There was a problem hiding this comment.
Let's add a TODO to remind us to bump up workers again once we've diagnosed the shutdown paths.
Contributor
Author
There was a problem hiding this comment.
Added a TODO beside the diagnostic command to restore --maxWorkers=800% and remove serial open-handle diagnostics once the shutdown paths have been diagnosed.
jrvb-rl
marked this pull request as ready for review
September 21, 2026 23:50
jason-rl
approved these changes
Sep 21, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable Jest open-handle diagnostics in the HTTP/1 and HTTP/2 smoketest jobs so the next normal dev/prod runs can identify resources preventing clean shutdown. This only gathers evidence; it does not change SDK cleanup or attempt a leak fix.
Motivation
All four transport jobs in the September 21 dev/prod runs passed their tests but reported a worker that could not exit gracefully and had to be terminated.
Changes
--runInBand --detectOpenHandlesinstead of--maxWorkers=800%.--forceExitor ignore errors.Jest detection requires serial execution and adds overhead. It can change reproduction of concurrency-sensitive leaks. If a handle remains open, the job may reach its timeout after printing diagnostics. This is diagnostic configuration to revisit after collecting evidence, not a permanent leak fix.
Testing
git diff --check.Breaking Changes
None to the SDK API. CI smoketests run serially while diagnostics are enabled.
Checklist