Skip to content

Remove obsolete brakeman.ignore entry for organizations/show #1931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maebeale merged 1 commit into from
Jul 4, 2026
+0 −34
Merged

Remove obsolete brakeman.ignore entry for organizations/show #1931

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 0 additions & 34 deletions config/brakeman.ignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,40 +238,6 @@
79
],
"note": "Admin-only reminder confirmation. Same as preview_reminder: the raw value is the server-rendered email HTML; the embedded custom message is sanitized via reminder_message_html (SafeListSanitizer) and the custom subject is shown escaped, separately, so no unsanitized user input reaches the page."
},
{
"warning_type": "Cross-Site Scripting",
"warning_code": 4,
"fingerprint": "081b76f4d760b6f2879493fdde335a57dfc310ba0adfb28d5abe40d5f983189f",
"check_name": "LinkToHref",
"message": "Potentially unsafe model attribute in `link_to` href",
"file": "app/views/organizations/show.html.erb",
"line": 88,
"link": "https://brakemanscanner.org/docs/warning_types/link_to_href",
"code": "link_to(Organization.includes(:organization_status, :windows_type, :addresses, :categorizable_items, { :comments => ([:created_by, :updated_by]) }, { :sectorable_items => :sector }, :affiliations => :person).find(params[:id]).website_url, Organization.includes(:organization_status, :windows_type, :addresses, :categorizable_items, { :comments => ([:created_by, :updated_by]) }, { :sectorable_items => :sector }, :affiliations => :person).find(params[:id]).website_link_url, :target => \"_blank\", :rel => \"noopener noreferrer\", :class => \"text-blue-600 hover:underline\")",
"render_path": [
{
"type": "controller",
"class": "OrganizationsController",
"method": "show",
"line": 74,
"file": "app/controllers/organizations_controller.rb",
"rendered": {
"name": "organizations/show",
"file": "app/views/organizations/show.html.erb"
}
}
],
"location": {
"type": "template",
"template": "organizations/show"
},
"user_input": "Organization.includes(:organization_status, :windows_type, :addresses, :categorizable_items, { :comments => ([:created_by, :updated_by]) }, { :sectorable_items => :sector }, :affiliations => :person).find(params[:id]).website_link_url",
"confidence": "Weak",
"cwe_id": [
79
],
"note": "Organization#website_link_url only ever returns an http(s):// URL (it requires a URI::HTTP with a host), so the href can't carry a javascript: or data: scheme."
}
],
"brakeman_version": "8.0.4",
Expand Down