Skip to content

Remove obsolete brakeman.ignore entry for organizations/show#1931

Merged
maebeale merged 1 commit into
mainfrom
maebeale/rebase-main-check
Jul 4, 2026
Merged

Remove obsolete brakeman.ignore entry for organizations/show#1931
maebeale merged 1 commit into
mainfrom
maebeale/rebase-main-check

Conversation

@maebeale

@maebeale maebeale commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator

🤖 PR, suggested 👤 review level: 👀 Skim — view-only: security-config cleanup, no code or data changes

  • Removes a stale LinkToHref ignore entry (fingerprint 081b76f4…) for organizations/show.html.erb. Main’s churn changed the code around that link_to, so brakeman no longer generates that fingerprint — the entry matched nothing.
  • Brakeman itself flagged it in its obsolete list. After removal: active=0 ignored=8 obsolete=[], exits clean. No new fingerprint appeared, so nothing needs re-ignoring.

🤖 Generated with Claude Code

Main's churn changed the code around the link_to, so brakeman no longer
generates fingerprint 081b76f4… — the ignore entry matched nothing.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 4, 2026 18:24
@maebeale maebeale marked this pull request as ready for review July 4, 2026 18:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an obsolete Brakeman ignore entry so the security ignore configuration reflects current warnings and no longer contains stale fingerprints.

Changes:

  • Deleted a stale LinkToHref (XSS) ignore entry targeting app/views/organizations/show.html.erb that no longer matches any Brakeman finding.

@maebeale maebeale merged commit 93177c6 into main Jul 4, 2026
4 checks passed
@maebeale maebeale deleted the maebeale/rebase-main-check branch July 4, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants