Skip to content

chore: build before stage publish #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chenjiahan wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: build before stage publish #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7438e1f
chore: build before stage publish
chenjiahan May 29, 2026
12ef418
chore: build before CI tests
chenjiahan May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,8 @@ jobs:
- name: Run lint
run: pnpm lint

- name: Build Packages
run: pnpm build

- name: Run tests
run: pnpm test
3 changes: 3 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,8 @@ jobs:
- name: Install Dependencies
run: pnpm i

- name: Build Packages
run: pnpm build

- name: Publish
run: pnpm stage publish --no-git-checks
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
"lint": "rslint",
"lint:write": "rslint --fix",
"prebundle": "node ./bin.js",
"prepare": "rslib",
"bump": "npx bumpp",
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore the build before CI tests

Removing prepare means the CI install step no longer runs rslib, and the checked .github/workflows/ci.yml still goes from pnpm install --frozen-lockfile to lint and then pnpm test without any build step. The tests execute bin.js, which imports ./dist/index.js, but dist/ is not tracked in a fresh checkout, so every CI test job will fail with the missing dist module unless prepare is kept or CI/test builds first.

Useful? React with 👍 / 👎.

"test": "rstest"
},
Expand Down
Loading