chore: build before stage publish#79
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7438e1f6f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "lint:write": "rslint --fix", | ||
| "prebundle": "node ./bin.js", | ||
| "prepare": "rslib", | ||
| "bump": "npx bumpp", |
There was a problem hiding this comment.
Restore the build before CI tests
Removing prepare means the CI install step no longer runs rslib, and the checked .github/workflows/ci.yml still goes from pnpm install --frozen-lockfile to lint and then pnpm test without any build step. The tests execute bin.js, which imports ./dist/index.js, but dist/ is not tracked in a fresh checkout, so every CI test job will fail with the missing dist module unless prepare is kept or CI/test builds first.
Useful? React with 👍 / 👎.
Summary
pnpm stage publish.scripts.preparewhere present.Validation
pnpm build.git diff --check.