Repository navigation
Add stable resident GPU trimming for ICP - #177
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trimmed ICP currently transfers query/match payload per iteration and sorts retained pairs on CPU. Add explicit
align_with_gpu_trimmed_reductionand ownedGpuIcpTrimmedMoments: GPU transforms, matches, stably selects by distance/source index, and reduces retained-pair moments. Fitness and stopping continue to use all gated pairs, with 176 bytes downloaded per evaluation.Integer device limbs reproduce binary64 retained-count multiplication/rounding/floor. Fraction one delegates to canonical untrimmed kernels. Original inputs and private selection scratch stay resident through one submission; CPU target-tree construction, Horn pose solving and convergence remain.
Validation:
Precision limit: the 262,145-point partially gated, trim-0.8 case has a CPU pose-coordinate difference of 0.0008154977, exceeding the unchanged 3e-5 agreement threshold. Both successful surveys retain it with
within_pose_tolerance=false; it is excluded from pose-qualified speedup ranges. Counts/stopping and independent all-gated fitness checks agree, but its timing is not evidence of CPU-equivalent pose accuracy. Device f32 rounding can change retained subsets near ties; further precision investigation remains on the roadmap.Full measurement evidence and limits.
Depends on #176.