Repository navigation
Improve resident trimmed ICP moment precision - #178
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resident trimmed ICP previously accumulated normalized coordinates/products with f32 rounding. A partially gated 262,145-point registration exceeded the existing CPU pose agreement tolerance (0.0008154977).
Default retained-moment arithmetic now carries two f32 words through offsets, normalization, centroid division and covariance products. Integer mantissa products retain residuals; dependent runtime-zero bitcasts preserve intermediate rounding through compensated sums. The explicit
GpuIcpTrimPrecision::CompensatedF32choice retains the previous shader, with precision-selecting APIs in GPU and registration and a facade export.The same adverse case now has a maximum pose-coordinate difference of 0.0000076293945, within the unchanged 3e-5 threshold. Stable selection, f32 transforms/search, all-gated fitness, CPU Horn solving/stopping, six phases plus selection digits and fixed 176-byte readbacks remain. Fraction one preserves canonical ordinary results; transfers and device limits are unchanged. No dependencies, core changes or unsafe boundaries are added.
Validation:
Numerical limits remain for f32 matching near gates/ties, underflow/extreme dynamic range and degenerate geometry. Moment accuracy does not ensure uniformly smaller pose error for every input. The explicit previous arithmetic supports its performance tradeoff.
Evidence:
C:/Users/rsasa/Workspace/SpatialRust/notes/2026-10-13_gpu_icp_trimmed_precision.md. ROADMAP, architecture and CHANGELOG describe the final default and remaining solve boundaries. Follows merged PR #177.