Skip to content

Fix production bugs: missing binary error handling and file race conditions #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rootLocalGhost merged 1 commit into from
Jan 16, 2026
Merged

Fix production bugs: missing binary error handling and file race conditions #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/main/downloader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,11 @@ ${stderrOutput}`;
const info = JSON.parse(infoData);
await fs.promises.unlink(infoJsonPath);
const realId = info.id;
const mediaFile = files.find(

// Refresh file list to catch any file operations that completed in the meantime
const currentFiles = await fs.promises.readdir(this.videoPath);

const mediaFile = currentFiles.find(
(f) =>
(f.startsWith(videoInfo.id) || f.startsWith(realId)) &&
!f.endsWith('.json') &&
Expand All @@ -351,7 +355,7 @@ ${stderrOutput}`;
if (!mediaFile) throw new Error('Media file not found after download.');
const mediaFilePath = path.join(this.videoPath, mediaFile);
let finalCoverPath = null;
const thumbFile = files.find(
const thumbFile = currentFiles.find(
(f) =>
(f.startsWith(videoInfo.id) || f.startsWith(realId)) &&
(f.endsWith('.jpg') || f.endsWith('.webp'))
Expand All @@ -366,7 +370,7 @@ ${stderrOutput}`;
? url.pathToFileURL(finalCoverPath).href
: null;
let subFileUri = null;
const subFile = files.find(
const subFile = currentFiles.find(
(f) => f.startsWith(videoInfo.id) && f.endsWith('.vtt')
);
if (subFile) {
Expand All @@ -376,7 +380,7 @@ ${stderrOutput}`;
});
subFileUri = url.pathToFileURL(destSub).href;
}
const descFile = files.find(
const descFile = currentFiles.find(
(f) => f.startsWith(videoInfo.id) && f.endsWith('.description')
);
if (descFile)
Expand Down
Binary file modified src/main/main.js
View file
Open in desktop
Binary file not shown.