Fix production bugs: missing binary error handling and file race conditions #42
Conversation
…itions - Added error listeners to `spawn` calls in `src/main/main.js` to catch and report missing `yt-dlp` binaries gracefully instead of crashing or hanging. - Updated `src/main/downloader.js` to refresh the file list immediately after download completion, fixing a race condition where the `postProcess` method failed to find the downloaded file. - Corrected `sanitizeFilename` regex in `src/main/main.js` to properly preserve spaces while stripping illegal characters. - Verified platform-specific binary resolution logic for Windows and Linux.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This submission addresses critical production stability issues identified during the audit.
Key fixes include:
proc.on('error')handling toyt-dlpspawn events in the main process. Previously, if the binary was missing (common in fresh installs or broken builds), the application would crash or leave the frontend in a hung state.Downloaderclass now re-reads the directory contents immediately before processing a downloaded file. This resolves a race condition where the application checked for the file's existence before the filesystem had fully registered the write completion or move operation, leading to "Media file not found" errors on successful downloads.sanitizeFilenamethat was incorrectly flagging or replacing valid characters (or doing nothing useful) regarding spaces/hyphens. It now correctly targets only illegal filesystem characters.Verified with
npm testand by checking binary handling logic.PR created automatically by Jules for task 11570636485686627002 started by @rootLocalGhost