Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,9 @@ def _TH2Poly_AddBin(self, *args, **kwargs):
# "TH2PolyBin", Does not derive from TH2
"TProfile2D",
# "TProfile2PolyBin", Derives from TH2PolyBin which does not derive from TH2
"TProfile2Poly",
# "TProfile2Poly", # Like TH2Poly (its base), its bins are polygons addressed by a
# # single global bin number, not an (i, j) grid, so it does not fit
# # the rectangular UHI plotting/indexing model.
]

for klass in _th2_derived_classes_to_pythonize:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ def _add_indexing_features(klass: Any) -> None:
"TH3C": _values_by_copy,
"TProfile": _values_by_copy,
"TProfile2D": _values_by_copy,
"TProfile2Poly": _values_by_copy,
"TProfile3D": _values_by_copy,
}

Expand Down
2 changes: 1 addition & 1 deletion bindings/pyroot/pythonizations/test/uhi_indexing.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def _special_setting(hist):
# For these classes, SetBinContent works differently than for other classes,
# as in it does not set the bin content to the specified value, but does some other calculations
# for that, these classes will be tested differently
return isinstance(hist, (ROOT.TProfile, ROOT.TProfile2D, ROOT.TProfile2Poly, ROOT.TProfile3D))
return isinstance(hist, (ROOT.TProfile, ROOT.TProfile2D, ROOT.TProfile3D))


def _get_index_for_dimension(hist, index):
Expand Down
4 changes: 1 addition & 3 deletions bindings/pyroot/pythonizations/test/uhi_plotting.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@

def _not_writable(hist):
# For these classes, the values() method always returns a copy so writable=True is not supported.
return isinstance(
hist, (ROOT.TH1C, ROOT.TH2C, ROOT.TH3C, ROOT.TProfile, ROOT.TProfile2D, ROOT.TProfile2Poly, ROOT.TProfile3D)
)
return isinstance(hist, (ROOT.TH1C, ROOT.TH2C, ROOT.TH3C, ROOT.TProfile, ROOT.TProfile2D, ROOT.TProfile3D))


class TestTH1Plotting:
Expand Down
Loading