[UHI] Exclude TProfile2Poly from the UHI interface#22699
Open
guitargeek wants to merge 1 commit into
Open
Conversation
siliataider
approved these changes
Jun 25, 2026
siliataider
left a comment
siliataider
left a comment
Contributor
There was a problem hiding this comment.
Makes sense, thanks!
TProfile2Poly derives from TH2Poly, whose bins are polygons addressed by a single global bin number rather than an (i, j) grid. The UHI plotting and indexing pythonizations assume rectangular axes and access bins via the 2-D GetBinContent(i, j) / GetBinContent(*bin) overloads, which are not implemented for TH2Poly and only ever returned a dummy 0. As a result UHI support for TProfile2Poly was silently meaningless: the indexing and plotting tests compared 0 against 0 and passed vacuously, and a grid-constructed TProfile2Poly has no addressable bins at all (`GetNumberOfBins() == 0`). TH2Poly was already deliberately left out of the pythonized class list for this reason; TProfile2Poly had been included by oversight. and should also not be included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TProfile2Poly derives from TH2Poly, whose bins are polygons addressed by a single global bin number rather than an (i, j) grid. The UHI plotting and indexing pythonizations assume rectangular axes and access bins via the 2-D GetBinContent(i, j) / GetBinContent(*bin) overloads, which are not implemented for TH2Poly and only ever returned a dummy 0.
As a result UHI support for TProfile2Poly was silently meaningless: the indexing and plotting tests compared 0 against 0 and passed vacuously, and a grid-constructed TProfile2Poly has no addressable bins at all (
GetNumberOfBins() == 0).TH2Poly was already deliberately left out of the pythonized class list for this reason; TProfile2Poly had been included by oversight. and should also not be included.