Skip to content

fix(website): restore refactoring changes lost during rebase#4537

Closed
NathanFlurry wants to merge 1 commit intographite-base/4537from
03-30-fix_website_restore_refactoring_changes_lost_during_rebase
Closed

fix(website): restore refactoring changes lost during rebase#4537
NathanFlurry wants to merge 1 commit intographite-base/4537from
03-30-fix_website_restore_refactoring_changes_lost_during_rebase

Conversation

@NathanFlurry
Copy link
Copy Markdown
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@railway-app
Copy link
Copy Markdown

railway-app bot commented Mar 31, 2026

🚅 Deployed to the rivet-pr-4537 environment in rivet-frontend

Service Status Web Updated (UTC)
website 😴 Sleeping (View Logs) Web Mar 31, 2026 at 7:14 am
kitchen-sink ❌ Build Failed (View Logs) Web Mar 31, 2026 at 7:02 am
frontend-cloud ❌ Build Failed (View Logs) Web Mar 31, 2026 at 6:32 am
frontend-inspector ❌ Build Failed (View Logs) Web Mar 31, 2026 at 6:31 am
mcp-hub ✅ Success (View Logs) Web Mar 31, 2026 at 6:30 am
ladle ❌ Build Failed (View Logs) Web Mar 31, 2026 at 6:30 am

Copy link
Copy Markdown
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link
Copy Markdown

claude bot commented Mar 31, 2026

PR Review

This PR restores website refactoring changes lost during a rebase. It is primarily a large deletion PR removing the entire agent-os docs section, registry marketing pages, benchmark infrastructure, and associated utilities (-7589 lines net).

Issues

1. Missing redirects for deleted pages

Three routes are deleted without corresponding entries in astro.config.mjs redirects:

  • /registry (registry.astro deleted, 3 lines)
  • /agent-os/registry/ (index.astro deleted, 49 lines)
  • /agent-os/registry/[slug] ([slug].astro deleted, 115 lines)

If these were indexed or linked externally they will 404. At minimum /registry should redirect somewhere (e.g., /agent-os) since it is still referenced in the nav WHITE_THEMED_PATHS.

2. Stale entry in WHITE_THEMED_PATHS (Header.tsx)

/registry remains in WHITE_THEMED_PATHS in Header.tsx even though registry.astro is deleted in this same PR. Dead entry should be removed.

3. Import ordering in Header.tsx

const WHITE_THEMED_PATHS is declared at module scope between import statements (after the image imports but before import { cn }). It will not cause a runtime error, but it violates standard import-before-code module organization and may trip linters.

4. agent-os MDX docs deletion

25 MDX doc files under website/src/content/docs/agent-os/ are deleted (~4200 lines). The sitemap entry is also removed. Confirm these docs are intentionally retired and that any external deep links to /docs/agent-os/* are handled. The current astro.config.mjs has no redirects for those paths.

Positives

  • Removing RegistryPageClient.tsx, registry.ts, bench.ts, and the registry SVGs is good housekeeping.
  • TabsScript.astro goes from 46 lines to 1 line.
  • AgentOSUseCasesPage cleanup (100 to 35 lines) is clean.

@NathanFlurry NathanFlurry force-pushed the 03-30-fix_website_restore_refactoring_changes_lost_during_rebase branch from 6197aac to 914df74 Compare March 31, 2026 07:02
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4537 March 31, 2026 07:02 Destroyed
@NathanFlurry NathanFlurry changed the base branch from rivetkit-perf-fixes to graphite-base/4537 March 31, 2026 07:12
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4523 March 31, 2026 07:12 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant