Skip to content

refactor: marketing components#4535

Closed
NicholasKissel wants to merge 1 commit intorivetkit-perf-fixesfrom
NicholasKissel/refactor-marketing-components
Closed

refactor: marketing components#4535
NicholasKissel wants to merge 1 commit intorivetkit-perf-fixesfrom
NicholasKissel/refactor-marketing-components

Conversation

@NicholasKissel
Copy link
Copy Markdown
Member

Minor marketing page updates

🤖 Generated with Claude Code

@railway-app
Copy link
Copy Markdown

railway-app bot commented Mar 31, 2026

🚅 Deployed to the rivet-pr-4535 environment in rivet-frontend

Service Status Web Updated (UTC)
website 😴 Sleeping (View Logs) Web Mar 31, 2026 at 3:30 am
frontend-inspector 😴 Sleeping (View Logs) Web Mar 31, 2026 at 3:28 am
frontend-cloud 😴 Sleeping (View Logs) Web Mar 31, 2026 at 3:25 am
mcp-hub ✅ Success (View Logs) Web Mar 31, 2026 at 3:19 am
ladle ❌ Build Failed (View Logs) Web Mar 31, 2026 at 3:19 am
kitchen-sink ❌ Build Failed (View Logs) Web Mar 31, 2026 at 3:19 am

@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4535 March 31, 2026 03:18 Destroyed
@claude
Copy link
Copy Markdown

claude bot commented Mar 31, 2026

PR Review: refactor: marketing components

Overall this is solid marketing website work with good component structure and accessibility practices. A few items worth addressing before merge:


Must Fix

Domain mismatch: rivet.gg in Bluesky URL

Per CLAUDE.md, rivet.gg is deprecated and must never be used. Found in website/src/components/marketing/sections/CommunitySection.tsx:

href: 'https://bsky.app/profile/rivet.gg',  // incorrect
// should be:
href: 'https://bsky.app/profile/rivet.dev',

Font-weight mappings incorrect in fonts.css

The "Perfectly Nineties" font declarations use font-weight: normal for files named Extrabold.otf and Semibold.otf. This will cause browsers to render the wrong weight:

/* Incorrect — Extrabold should be 800, Semibold should be 600 */
font-weight: normal;
src: url('./fonts/PerfectlyNineties-Extrabold.otf') format('opentype');

Should Fix

Unused ref in website/src/components/v2/Header.tsx

isHoveringRef is written to but never read — it can be removed:

const isHoveringRef = useRef(false);       // defined
isHoveringRef.current = true;              // written in event handler
// never read anywhere — dead code

sheetClassName prop added to Header but not used in diff

The prop is declared and destructured in frontend/packages/components/src/header/index.tsx but it does not appear to be passed to anything in the diff. Verify it's wired up or remove it if unused.


Maintainability Notes (non-blocking)

Duplicated CopyButton / CopyInstallButton — Near-identical copy-to-clipboard components are defined separately in AgentOSPricingPage.tsx, AgentOSUseCasesPage.tsx, AgentOSSection.tsx, and GetStartedPage.tsx. Worth extracting to a shared component in a follow-up.

Repeated framer-motion animation props — The pattern initial={{ opacity: 0, y: 20 }} whileInView={{ opacity: 1, y: 0 }} viewport={{ once: true }} transition={{ duration: 0.5 }} appears throughout many files. Defining it as a shared constant would make it easier to tweak globally.

WHITE_THEMED_PATHS duplicated — This array exists in both v2/Header.tsx and Footer.jsx. Extracting to a shared constant would prevent them drifting out of sync.


What's Well Done

  • Accessibility is solid throughout: proper aria-current, aria-label, alt attributes, and semantic HTML.
  • TimelinePage.tsx is clean and well-structured.
  • RedesignedHero.tsx Game of Life canvas animation is impressively implemented.
  • ProblemSection.tsx Shiki syntax highlighting integration is well handled.
  • Astro page files are clean with proper layouts.
  • Good use of loading="lazy" and decoding="async" on images.

🤖 Generated with Claude Code

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 31, 2026

More templates

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@4535

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@4535

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@4535

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@4535

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@4535

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@4535

@rivetkit/sqlite-vfs

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sqlite-vfs@4535

@rivetkit/traces

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/traces@4535

@rivetkit/workflow-engine

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/workflow-engine@4535

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@4535

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@4535

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@4535

commit: d587606

Add new page at /agent-os/use-cases showcasing who agentOS is for:
- Background agents
- Production agents
- Efficient evals
- Browser-based LLM interfaces
- Programming agents
- Personal agents
- Multi-agent systems
- Customer support agents
- DevOps agents
- Data processing agents
- Content creation agents
- Workflow automation

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@NathanFlurry NathanFlurry changed the base branch from main to graphite-base/4535 March 31, 2026 06:11
@NathanFlurry NathanFlurry force-pushed the NicholasKissel/refactor-marketing-components branch from d587606 to e89e6e1 Compare March 31, 2026 06:11
@NathanFlurry NathanFlurry changed the base branch from graphite-base/4535 to rivetkit-perf-fixes March 31, 2026 06:11
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4535 March 31, 2026 06:11 Destroyed
Copy link
Copy Markdown
Member

NathanFlurry commented Mar 31, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants