fix(cache): clean up lib

[MasterPtato]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[railway-app]

🚅 Deployed to the rivet-pr-4457 environment in rivet-frontend

Service	Status	Web	Updated (UTC)
frontend-cloud	😴 Sleeping (View Logs)	Web	Mar 31, 2026 at 5:50 am
frontend-inspector	😴 Sleeping (View Logs)	Web	Mar 22, 2026 at 10:18 am
website	❌ Build Failed (View Logs)	Web	Mar 19, 2026 at 2:08 am
mcp-hub	✅ Success (View Logs)	Web	Mar 19, 2026 at 2:07 am
ladle	❌ Build Failed (View Logs)	Web	Mar 19, 2026 at 2:06 am

[MasterPtato]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• chore: envoy client #4521 : 2 dependent PRs (#4531 , #4534 )
• feat(pb): actors v3 #4463
• feat(ups): implement queue subs #4486
• feat(cache): add in flight deduping #4459
• fix(cache): clean up lib #4457 👈 (View in Graphite)
• fix(config): allow configuring topo dcs via map, fix pg ssl mode config #4456
• fix(api): dont 500 on cross dc response #4449
• chore: update byte units on frontend #4444
• fix: runner alloc idx logic, api auth for actor get #4443
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[pkg-pr-new]

More templates

• actor-actions
• actor-actions-vercel
• ai-agent
• ai-agent-vercel
• example-ai-and-user-generated-actors-freestyle
• chat-room
• chat-room-vercel
• example-cloudflare-workers
• example-cloudflare-workers-hono
• collaborative-document
• collaborative-document-vercel
• cross-actor-actions
• cross-actor-actions-vercel
• example-cursors
• example-cursors-raw-websocket
• example-cursors-raw-websocket-vercel
• example-cursors-vercel
• custom-serverless
• example-elysia
• example-experimental-durable-streams-ai-agent
• example-experimental-durable-streams-ai-agent-vercel
• geo-distributed-database
• geo-distributed-database-vercel
• hello-world
• hello-world-vercel
• example-hono
• hono-react
• hono-react-vercel
• example-kitchen-sink
• example-kitchen-sink-vercel
• multi-region-vercel
• multiplayer-game
• example-multiplayer-game-patterns
• example-multiplayer-game-patterns-vercel
• multiplayer-game-vercel
• native-websockets
• native-websockets-vercel
• next-js
• per-tenant-database
• per-tenant-database-vercel
• example-raw-fetch-handler
• example-raw-fetch-handler-vercel
• example-raw-websocket-handler
• example-raw-websocket-handler-proxy
• example-raw-websocket-handler-proxy-vercel
• example-raw-websocket-handler-vercel
• example-react
• example-react-vercel
• sandbox
• sandbox-coding-agent
• sandbox-coding-agent-vercel
• sandbox-vercel
• scheduling
• scheduling-vercel
• example-sqlite-drizzle
• example-sqlite-raw
• state
• state-vercel
• example-stream
• example-stream-vercel
• example-trpc

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@4457

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@4457

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@4457

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@4457

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@4457

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@4457

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@4457

@rivetkit/sqlite-vfs

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sqlite-vfs@4457

@rivetkit/traces

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/traces@4457

@rivetkit/workflow-engine

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/workflow-engine@4457

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@4457

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@4457

commit: e65f84d

[claude]

PR Review: fix(cache): clean up lib

Summary

This PR cleans up the rivet-cache library by removing Redis support (which was only a todo!()), eliminating the in-memory rate-limiting subsystem, removing the generic fetch_one/fetch_all wrappers in favor of the JSON-specific variants, and replacing loose String key types with the typed RawCacheKey newtype. Net result: -309 lines with no apparent functional regression for current callers.

---

Issues

Medium

• inner.rs:29 — Undocumented 10x capacity increase: max_capacity silently changed from 1000 to 10000. No comment, PR description mention, or test coverage explains the rationale. Worth at least a comment explaining the new value.

• Rate limiting removal — no migration note: rate_limit.rs, RateLimitConfig, and CacheInner::rate_limit are fully deleted. The PR description does not explain whether rate limiting is being moved to another layer or dropped entirely. If it is being removed permanently, that is a behavior change worth calling out explicitly.

Low

• req_config.rs:3 — use anyhow::*; glob import: CLAUDE.md says "Do not glob import from anyhow. Instead, import individual types and traits." This pre-exists the PR but since the file was significantly reworked, it is a good opportunity to fix.

• req_config.rs log messages use title case: "Failed to decode value" and "Failed to encode value" — CLAUDE.md convention is lowercase log messages unless referencing specific code symbols.

• key.rs:109-115 — Deref<Target = String> is non-idiomatic: The standard Rust convention is Deref<Target = str>. With Target = String, the full String API is transitively exposed on RawCacheKey, which is wider than intended. Callers already use &*key to get a &str, so changing the target to str would be cleaner.

• driver.rs — Misleading doc comment on process_key: The comment states "In-memory uses simpler keys" but the base key parameter passed to get/delete in InMemoryDriver is intentionally ignored (_base_key). The comment should be removed or reworded.

---

Positives

• The rename of fetch_values/set_values/delete_keys to get/set/delete on the driver trait is a clean improvement.
• Moving serialization responsibility entirely into req_config.rs (removing encode_value/decode_value from Driver) is the right layering.
• Switching the cache write task clone from driver to cache (Arc<CacheInner>) is correct given Driver no longer derives Clone.
• Removing the second rate_limits: Cache<String, ExpiringValue> from InMemoryDriver halves the memory overhead per instance.

---

Generated by Claude Code