chore: update byte units on frontend by MasterPtato · Pull Request #4444 · rivet-dev/rivet

MasterPtato · 2026-03-17T19:38:04Z

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

railway-app · 2026-03-17T19:38:15Z

🚅 Deployed to the rivet-pr-4444 environment in rivet-frontend

Service	Status	Web	Updated (UTC)
frontend-inspector	😴 Sleeping (View Logs)	Web	Mar 31, 2026 at 10:56 am
frontend-cloud	😴 Sleeping (View Logs)	Web	Mar 31, 2026 at 10:05 am
ladle	❌ Build Failed (View Logs)	Web	Mar 17, 2026 at 7:43 pm
website	❌ Build Failed (View Logs)	Web	Mar 17, 2026 at 7:41 pm
mcp-hub	✅ Success (View Logs)	Web	Mar 17, 2026 at 7:39 pm

MasterPtato · 2026-03-17T19:38:16Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

chore: envoy client #4521 : 2 dependent PRs (#4531 , #4534 )
feat(pb): actors v3 #4463
feat(ups): implement queue subs #4486
feat(cache): add in flight deduping #4459
fix(cache): clean up lib #4457
fix(config): allow configuring topo dcs via map, fix pg ssl mode config #4456
fix(api): dont 500 on cross dc response #4449
chore: update byte units on frontend #4444 👈 (View in Graphite)
fix: runner alloc idx logic, api auth for actor get #4443
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

claude · 2026-03-17T19:40:06Z

PR Review: chore: update byte units on frontend

Files changed: 5 files, +42 / -44 lines

Summary

This PR migrates billing-related frontend labels and computed values from SI (decimal, base-1000) byte units (KB/MB/GB/TB) to IEC (binary, base-1024) units (KiB/MiB/GiB/TiB). Changes span display labels, inline constant definitions, comments, and the bigBytes utility used in billing threshold calculations.

Key Question: Backend Unit Convention

The most important aspect of this PR is that billing.ts does not just rename labels - it also changes the actual byte thresholds used for plan inclusion comparisons:

Metric	Old (base-1000)	New (base-1024)	Delta
`kv_storage_used` free/pro/team	5,000,000,000 B	5,368,709,120 B	~+7.4%
`gateway_egress` free plan	100,000,000,000 B	107,374,182,400 B	~+7.4%
`gateway_egress` pro/team	1,000,000,000,000 B	1,099,511,627,776 B	~+10%
`kv_read`/`kv_write` unit size	4,000 B per op	4,096 B per op	~+2.4%

These are intentional if the backend measures usage in IEC (binary) units. However, if the backend still measures in SI (decimal) units, the displayed thresholds would be misleading after this change. Please confirm the backend unit convention matches before merging.

Inline Constants in `usage-card.tsx`

frontend/src/app/billing/usage-card.tsx defines its own local KiB/MiB/GiB/TiB constants inline rather than importing from the existing @/utils/bytes utility. The formatMetricValue "bytes" case is also a hand-rolled reimplementation of formatBytes from that same utility. Consider replacing both with formatBytes(num) to reduce duplication and keep formatting consistent across the app.

Minor: Double Blank Line in `billing.ts`

Removing the three inline const GB/TB/KB bigint constants leaves a double blank line between the type BilledMetrics block and the export const BILLING declaration. Not functional, just cosmetic.

`metrics/constants.ts` - Comment Fix Only

The change here is a comment fix (// 4KB operation units to // 4KiB operation units). The actual computation already used bytes.KiB(4) (base-1024 correct) before this PR, so the fix is accurate.

Overall

The changes are internally consistent and a clear improvement over the prior SI labels. The only pre-merge gate is confirming the backend uses IEC (base-1024) units. If so, this PR corrects a longstanding frontend mismatch and can merge as-is.

pkg-pr-new · 2026-03-17T19:42:13Z

More templates

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@4444

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@4444

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@4444

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@4444

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@4444

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@4444

@rivetkit/sqlite-vfs

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sqlite-vfs@4444

@rivetkit/traces

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/traces@4444

@rivetkit/workflow-engine

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/workflow-engine@4444

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@4444

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@4444

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@4444

commit: 388ad2e

railway-app bot had a problem deploying to rivet-frontend / rivet-pr-4444 March 17, 2026 19:38 Failure

MasterPtato mentioned this pull request Mar 17, 2026

fix: runner alloc idx logic, api auth for actor get #4443

Open

11 tasks

MasterPtato requested review from NicholasKissel and jog1t March 17, 2026 19:38

MasterPtato force-pushed the 03-17-chore_update_byte_units_on_frontend branch from f1b6d0a to d4011f0 Compare March 17, 2026 20:38

MasterPtato force-pushed the 03-17-fix_runner_alloc_idx_logic_api_auth_for_actor_get branch from 5b2bead to cfc4fad Compare March 17, 2026 20:38

railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4444 March 17, 2026 20:38 Destroyed

MasterPtato mentioned this pull request Mar 17, 2026

fix(api): dont 500 on cross dc response #4449

Open

11 tasks

MasterPtato force-pushed the 03-17-chore_update_byte_units_on_frontend branch from d4011f0 to 3b845cb Compare March 18, 2026 22:12

MasterPtato force-pushed the 03-17-fix_runner_alloc_idx_logic_api_auth_for_actor_get branch from cfc4fad to 65280b5 Compare March 18, 2026 22:12

MasterPtato requested a review from NathanFlurry March 18, 2026 22:13

This was referenced Mar 18, 2026

fix(config): allow configuring topo dcs via map, fix pg ssl mode config #4456

Open

fix(cache): clean up lib #4457

Open

feat(cache): add in flight deduping #4459

Open

MasterPtato force-pushed the 03-17-fix_runner_alloc_idx_logic_api_auth_for_actor_get branch from 65280b5 to 84dbf32 Compare March 21, 2026 01:55

MasterPtato force-pushed the 03-17-chore_update_byte_units_on_frontend branch from 3b845cb to 1028b2c Compare March 21, 2026 01:55

MasterPtato mentioned this pull request Mar 21, 2026

feat(pb): actors v3 #4463

Draft

11 tasks

MasterPtato force-pushed the 03-17-fix_runner_alloc_idx_logic_api_auth_for_actor_get branch from 84dbf32 to 90c2e97 Compare March 24, 2026 00:30

MasterPtato force-pushed the 03-17-chore_update_byte_units_on_frontend branch from 1028b2c to 88d15c3 Compare March 24, 2026 00:30

MasterPtato mentioned this pull request Mar 24, 2026

feat(ups): implement queue subs #4486

Draft

11 tasks

MasterPtato force-pushed the 03-17-chore_update_byte_units_on_frontend branch from 88d15c3 to ede07de Compare March 24, 2026 00:36

MasterPtato force-pushed the 03-17-fix_runner_alloc_idx_logic_api_auth_for_actor_get branch from 90c2e97 to ebdaa13 Compare March 24, 2026 00:36

MasterPtato force-pushed the 03-17-chore_update_byte_units_on_frontend branch from ede07de to e9536ed Compare March 25, 2026 00:05

MasterPtato force-pushed the 03-17-fix_runner_alloc_idx_logic_api_auth_for_actor_get branch 2 times, most recently from 63b3a1f to 73107a6 Compare March 26, 2026 01:18

MasterPtato force-pushed the 03-17-chore_update_byte_units_on_frontend branch from e9536ed to cf68e1c Compare March 26, 2026 01:18

MasterPtato force-pushed the 03-17-fix_runner_alloc_idx_logic_api_auth_for_actor_get branch from 73107a6 to b2f4422 Compare March 26, 2026 20:50

MasterPtato force-pushed the 03-17-chore_update_byte_units_on_frontend branch from cf68e1c to 0422e8d Compare March 26, 2026 20:50

MasterPtato force-pushed the 03-17-fix_runner_alloc_idx_logic_api_auth_for_actor_get branch from b2f4422 to 7baeb4c Compare March 28, 2026 00:20

MasterPtato force-pushed the 03-17-chore_update_byte_units_on_frontend branch from 0422e8d to 1cb5f34 Compare March 28, 2026 00:20

This was referenced Mar 28, 2026

chore: envoy client #4521

Draft

chore: envoy client + tunnel slop #4531

Draft

MasterPtato force-pushed the 03-17-chore_update_byte_units_on_frontend branch from 1cb5f34 to 34988dd Compare March 30, 2026 19:40

chore: update byte units on frontend

388ad2e

MasterPtato force-pushed the 03-17-fix_runner_alloc_idx_logic_api_auth_for_actor_get branch from 791a38d to d5c2eee Compare March 31, 2026 01:40

MasterPtato force-pushed the 03-17-chore_update_byte_units_on_frontend branch from 34988dd to 388ad2e Compare March 31, 2026 01:40

MasterPtato mentioned this pull request Mar 31, 2026

feat: basic envoy tunnel impl #4534

Draft

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update byte units on frontend#4444

chore: update byte units on frontend#4444
MasterPtato wants to merge 1 commit into03-17-fix_runner_alloc_idx_logic_api_auth_for_actor_getfrom
03-17-chore_update_byte_units_on_frontend

MasterPtato commented Mar 17, 2026

Uh oh!

railway-app bot commented Mar 17, 2026 •

edited

Loading

Uh oh!

MasterPtato commented Mar 17, 2026 •

edited

Loading

Uh oh!

claude bot commented Mar 17, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Mar 17, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

MasterPtato commented Mar 17, 2026

Description

Type of change

How Has This Been Tested?

Checklist:

Uh oh!

railway-app bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MasterPtato commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review: chore: update byte units on frontend

Summary

Key Question: Backend Unit Convention

Inline Constants in usage-card.tsx

Minor: Double Blank Line in billing.ts

metrics/constants.ts - Comment Fix Only

Overall

Uh oh!

pkg-pr-new bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

railway-app bot commented Mar 17, 2026 •

edited

Loading

MasterPtato commented Mar 17, 2026 •

edited

Loading

claude bot commented Mar 17, 2026 •

edited

Loading

Inline Constants in `usage-card.tsx`

Minor: Double Blank Line in `billing.ts`

`metrics/constants.ts` - Comment Fix Only

pkg-pr-new bot commented Mar 17, 2026 •

edited

Loading