Repository navigation
ci: the Dev Drive is mounted beside the checkout, so the Rust cache on Windows keeps its target - #96
Merged
Conversation
…n Windows keeps its target
4 of 7 tasks
rgdevment
added a commit
that referenced
this pull request
Nov 16, 2026
…, so the Mac checks pass again (#97) ## Context Rust 1.100 puts a build script's `OUT_DIR` one folder deeper than before. `tauri-build` 2.6.3 finds the target folder by going three levels up from it, so it now lands in `target/debug/build` and copies the sidecar there. On macOS a folder of that name is already there, the build folder of the `linkunbound-shell` package itself, and removing it as a file fails with "Operation not permitted": every macOS build stops in the build script of `linkunbound-settings`. It showed first in the macOS test job of #96, at `cargo clippy`; the release builds on stable too. On Windows the `.exe` in the name avoids the clash, and the sidecar still lands in the wrong folder. `tauri-build` 2.7.0 walks up from `OUT_DIR` to the `build` folder instead of counting levels. This moves the lockfile to 2.7.4. ## Reading order 1. `Cargo.lock`: `tauri-build` 2.6.3 to 2.7.4 and, with it, `tauri-utils` 2.9.3 to 2.10.3 and `urlpattern` 0.3 to 0.6; about 30 packages move in all. `tauri` itself stays at 2.11.6. 2. `THIRD-PARTY-BUNDLED.md`, `THIRD-PARTY-LICENSES.md`: written again from the new lockfile by `npm run notices`. ## Decisions | Decision | Discarded alternative | Reason | | :-- | :-- | :-- | | Move `tauri-build` to 2.7 | Hold CI on Rust 1.99.1 | The release builds on stable as well, and a Mac with Rust 1.100 cannot build the app at all until this moves | | 2.7.4 | 2.7.5, the newest | It is the version Tisty and CopyPaste already build with | | `tauri` stays at `~2.11` | Move it to 2.12 with the rest | `Cargo.toml` holds it there: 2.12 brings muda 0.20 while slint stays on 0.19, and two muda break the macOS link | ## Notes for reviewers `tauri` 2.11.6 beside `tauri-utils` 2.10.3 is a pairing no repository here has run: Tisty and CopyPaste pair `tauri` 2.12.5 with `tauri-utils` 2.10.2. `tauri-utils` ships inside the app, and this branch builds no installer on its own (`packaging=false`), so the steps below are worth taking before the merge. ## How to test 1. Run the `Bundle` workflow by hand on this branch → the Windows installer and the macOS bundle build. 2. Install one of them and open LinkUnbound → the settings window opens. 3. Open a link from another app → the picker shows and the chosen browser opens it. ## Checklist - [x] `cargo deny check bans licenses sources`: bans ok, licenses ok, sources ok - [x] `npm run notices`: 11 packages and 363 crates, both files written again - [x] No crate in the new tree declares a `rust-version` above the repository's 1.97 (`cargo metadata --locked`) - [x] `bash scripts/touched.sh` answers `rust=true`, so the Windows and macOS test jobs run on this pull request - [ ] The macOS test job passes here; on main's tree it fails with Rust 1.100, as in #96 - [ ] `Bundle`, run by hand on this branch, builds both - [ ] After merge: open the app once on Windows and on macOS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
On Windows the tests build on a Dev Drive, and the Rust cache was handed
E:/targetas a path under the checkout. It read that as a folder that does not exist, so the cache held the registry and nothing built: 172 MB on main, where macOS keeps 1,092 MB. With no other compile cache in this job, every Windows run built every dependency from nothing.This mounts the Dev Drive beside the checkout, at
../dev-drive, so the cache reaches its target by a relative path and keeps it. Nothing here can be tried by hand: it is CI only.Reading order
.github/workflows/ci.yml, jobtest:mount-pathon the Dev Drive step, theworkspacesline of the Rust cache, and thetest -d ../dev-drive/targetthat now follows themkdir.Decisions
../dev-driveE:/targetrust-cachejoins the target to the checkout's path, so a path on another drive names no foldertarget/rust-cachewalks the checkout for its key and would meet the drive'sSystem Volume Informationthere;TEMPalso stays out of the repositorytest -d ../dev-drive/targetafter themkdirChecklist
actionlintandzizmor --offline --min-severity medium .github: no findingsbash scripts/touched.shon this branch answersrust=true, so the Windows test job runs on this pull requestv0-rust-workspace-Windows_NT-x64-…is written with the target inside, well above today's 172 MB. Its key changes with the target's path, so a Windows job that runs before main writes it finds no cache at all, registry included