Repository navigation
build(deps): tauri-build 2.7 puts the sidecar where Rust 1.100 builds, so the Mac checks pass again - #97
Merged
Conversation
…, so the Mac checks pass again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Rust 1.100 puts a build script's
OUT_DIRone folder deeper than before.tauri-build2.6.3 finds the target folder by going three levels up from it, so it now lands intarget/debug/buildand copies the sidecar there. On macOS a folder of that name is already there, the build folder of thelinkunbound-shellpackage itself, and removing it as a file fails with "Operation not permitted": every macOS build stops in the build script oflinkunbound-settings. It showed first in the macOS test job of #96, atcargo clippy; the release builds on stable too. On Windows the.exein the name avoids the clash, and the sidecar still lands in the wrong folder.tauri-build2.7.0 walks up fromOUT_DIRto thebuildfolder instead of counting levels. This moves the lockfile to 2.7.4.Reading order
Cargo.lock:tauri-build2.6.3 to 2.7.4 and, with it,tauri-utils2.9.3 to 2.10.3 andurlpattern0.3 to 0.6; about 30 packages move in all.tauriitself stays at 2.11.6.THIRD-PARTY-BUNDLED.md,THIRD-PARTY-LICENSES.md: written again from the new lockfile bynpm run notices.Decisions
tauri-buildto 2.7tauristays at~2.11Cargo.tomlholds it there: 2.12 brings muda 0.20 while slint stays on 0.19, and two muda break the macOS linkNotes for reviewers
tauri2.11.6 besidetauri-utils2.10.3 is a pairing no repository here has run: Tisty and CopyPaste pairtauri2.12.5 withtauri-utils2.10.2.tauri-utilsships inside the app, and this branch builds no installer on its own (packaging=false), so the steps below are worth taking before the merge.How to test
Bundleworkflow by hand on this branch → the Windows installer and the macOS bundle build.Checklist
cargo deny check bans licenses sources: bans ok, licenses ok, sources oknpm run notices: 11 packages and 363 crates, both files written againrust-versionabove the repository's 1.97 (cargo metadata --locked)bash scripts/touched.shanswersrust=true, so the Windows and macOS test jobs run on this pull requestBundle, run by hand on this branch, builds both