-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Fix demo_form_dialog to omit trigger when not provided #6940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
masenf
wants to merge
2
commits into
main
Choose a base branch
from
claude/fragment-render-demo-form-2j4sdh
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+33
−3
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
tests/units/reflex_components_internal/blocks/test_demo_form.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| """Tests for the demo form block.""" | ||
|
|
||
| import re | ||
|
|
||
| from reflex_components_internal.blocks.demo_form import demo_form_dialog | ||
|
|
||
| import reflex as rx | ||
|
|
||
| RENDER_PROP_PATTERN = re.compile(r"render:\(jsx\((\w+)") | ||
| TRIGGER_LABEL = "Show me the demo form" | ||
|
|
||
|
|
||
| def test_demo_form_dialog_omits_trigger_when_not_given() -> None: | ||
| """A dialog without a trigger renders no trigger instead of an empty fragment.""" | ||
| rendered = str(demo_form_dialog()) | ||
|
|
||
| assert "Dialog.Trigger" not in rendered | ||
| # A Fragment cannot receive the props and ref that a base-ui render prop | ||
| # forwards to it, which makes React complain at runtime. | ||
| assert "Fragment" not in RENDER_PROP_PATTERN.findall(rendered) | ||
|
|
||
|
|
||
| def test_demo_form_dialog_renders_given_trigger() -> None: | ||
| """A dialog with a trigger renders it through the trigger's render prop.""" | ||
| # The dialog body has fixed copy of its own, so the label must be one that | ||
| # only the trigger can contribute. | ||
| assert TRIGGER_LABEL not in str(demo_form_dialog()) | ||
|
|
||
| rendered = str(demo_form_dialog(trigger=rx.el.button(TRIGGER_LABEL))) | ||
|
|
||
| assert "Dialog.Trigger" in rendered | ||
| assert TRIGGER_LABEL in rendered | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.