Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -404,11 +404,9 @@ def demo_form_dialog(
Returns:
A Reflex dialog component containing the demo form
"""
if trigger is None:
trigger = rx.fragment()
class_name = cn("w-auto", props.pop("class_name", ""))
return dialog.root(
dialog.trigger(render_=trigger),
dialog.trigger(render_=trigger) if trigger is not None else None,
dialog.portal(
dialog.backdrop(),
dialog.popup(
Expand Down
32 changes: 32 additions & 0 deletions tests/units/reflex_components_internal/blocks/test_demo_form.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
"""Tests for the demo form block."""

import re

from reflex_components_internal.blocks.demo_form import demo_form_dialog

import reflex as rx
Comment thread
masenf marked this conversation as resolved.

RENDER_PROP_PATTERN = re.compile(r"render:\(jsx\((\w+)")
TRIGGER_LABEL = "Show me the demo form"


def test_demo_form_dialog_omits_trigger_when_not_given() -> None:
"""A dialog without a trigger renders no trigger instead of an empty fragment."""
rendered = str(demo_form_dialog())

assert "Dialog.Trigger" not in rendered
# A Fragment cannot receive the props and ref that a base-ui render prop
# forwards to it, which makes React complain at runtime.
assert "Fragment" not in RENDER_PROP_PATTERN.findall(rendered)


def test_demo_form_dialog_renders_given_trigger() -> None:
"""A dialog with a trigger renders it through the trigger's render prop."""
# The dialog body has fixed copy of its own, so the label must be one that
# only the trigger can contribute.
assert TRIGGER_LABEL not in str(demo_form_dialog())

rendered = str(demo_form_dialog(trigger=rx.el.button(TRIGGER_LABEL)))

assert "Dialog.Trigger" in rendered
assert TRIGGER_LABEL in rendered
Loading