Fix demo_form_dialog to omit trigger when not provided

[masenf]

Type of change

• Bug fix (non-breaking change which fixes an issue)

Description

Fixed demo_form_dialog() to properly handle the case when no trigger is provided. Previously, the function would create an empty rx.fragment() as a fallback trigger, which caused React runtime warnings because Fragment components cannot receive the props and ref that base-ui's render prop forwards to them.

Changes:

• Removed the automatic rx.fragment() fallback when trigger is None
• Modified the dialog to conditionally render dialog.trigger() only when a trigger is explicitly provided
• This prevents Fragment from being used as a render prop target, eliminating React warnings

Testing

• Added unit tests in tests/units/reflex_components_internal/blocks/test_demo_form.py:
  • test_demo_form_dialog_omits_trigger_when_not_given(): Verifies that no trigger is rendered when none is provided
  • test_demo_form_dialog_renders_given_trigger(): Verifies that a provided trigger is properly rendered

Both tests pass and validate the fix works as intended.

https://claude.ai/code/session_01FcXXMZnAkNtwBj7v2bshXH

[cubic-dev-ai]

All reported issues were addressed across 2 files

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[codspeed-hq]

Merging this PR will not alter performance

✅ 27 untouched benchmarks
⏩ 8 skipped benchmarks¹

---

_{Comparing claude/fragment-render-demo-form-2j4sdh (7604652) with main (6b44604)}

Footnotes

1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[greptile-apps]

Greptile Summary

The PR updates demo_form_dialog to omit dialog.trigger when no trigger is supplied, avoiding an invalid Fragment render-prop target.

• Conditionally includes the dialog trigger only for an explicitly supplied component.
• Adds tests covering dialogs with and without a trigger.

Confidence Score: 4/5

The PR should not merge until the outstanding import-order violation in the new test file is corrected so the lint gate passes.

The functional fix is focused, but the new test file still has the import ordering reported in the prior thread, which violates the repository’s isort convention and is rejected or modified by the configured Ruff check.

Files Needing Attention: tests/units/reflex_components_internal/blocks/test_demo_form.py

Important Files Changed

Filename	Overview
packages/reflex-components-internal/src/reflex_components_internal/blocks/demo_form.py	Conditionally renders dialog.trigger so triggerless dialogs no longer create an empty Fragment render target.
tests/units/reflex_components_internal/blocks/test_demo_form.py	Adds focused trigger-rendering regression tests, but the outstanding import ordering causes the configured lint gate to reject or rewrite the file.

_{Reviews (2): Last reviewed commit: "test(internal): assert the demo form tri..." | Re-trigger Greptile}