docs: fix manifest path and filesystem scheme in serve.md#109
Open
lovrozitnik wants to merge 1 commit intoreadium:developfrom
Open
docs: fix manifest path and filesystem scheme in serve.md#109lovrozitnik wants to merge 1 commit intoreadium:developfrom
lovrozitnik wants to merge 1 commit intoreadium:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix manifest URL path and filesystem scheme documentation in serve.md
Summary
The documented manifest path doesn't match the route registered in the v0.6.6 binary. This PR corrects three related issues in
docs/serve.md:/webpub/{base64url}/manifest.json, not/{base64url}/manifest.json./webpub/prefix.file://is used; v0.6.6 accepts only a bare relative path with no URI prefix.Changes
/webpub/prefix to the manifest path description./webpub/to the HTTPS example URL.Verification
Tested against
readium v0.6.6 (go-toolkit v0.13.4)on Linux x86_64, serving a local EPUB:Working request:
Without the
/webpub/prefix, requests return 404. Passing afile://-prefixed path to the filesystem scheme produces an error (the decoded path is concatenated onto--file-directoryrather than parsed as a URI), confirmingfile://is not supported for the filesystem scheme in the released binary.Out of scope (separate issues to be filed)
/list.jsonendpoint does not appear in the v0.6.6 binary (confirmed viastrings); may be a regression or develop-only feature.--debugproduces no per-request logging, making 404/500 troubleshooting difficult.file://URI to the filesystem scheme produces a confusing path-concatenation error rather than a clear "URI scheme not supported" message.