Repository navigation
Spec 013 T023 done: search and service in TypeScript, and no plain JS left in tools/ - #652
Merged
Merged
Conversation
… left in tools/ The last batch of the .mjs specs: tools/content-node's search and service specs (the largest, 2,215 lines) and the library-update spec, 252 errors with checkJs on. Each is now a .ts spec, typed and held at zero on both counts. - search: the stand-in Solr's answer typed as (request, form, response); the queue tests' held responses and settled answers typed; an extended collation passed as a value rather than a literal its type would refuse. - service: endpoints, answers and the error envelope read through helpers that throw where the old reads crashed (the declared normalisation, an answer's envelope, a node's children and parents, the nth item); graph rows that lack a property passed as rows, saying so; the fakes standing in for an Express request and response cast once each, naming the fields the code reads; Java-shaped tables typed as tuples. No .mjs is left in tools/. checkJs stays off, because the scripts the tools import from scripts/ and e2e/ are not part of this check, so tools/load.spec.ts now fails on any plain JavaScript module added under tools/ (shown failing on a probe file). T023 is complete. Same 249 tests as the .mjs versions of search and service, and 4 for the library spec, all passing; all 1,181 tools tests pass; types, lint (1,329) and dead code (131) unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec 013, T023: the last batch. Batch 6 was #651. This completes T023.
What changed. Three specs are converted:
tools/content-node's search and service specs (service is the largest, at 2,215 lines) and the library-update spec. They held 252 errors withcheckJson. Each is now a typed.tsspec, held at zero on both counts.search:
(request, form, response).service:
No plain JS left in
tools/..mjsremains.checkJsstays off, because the scripts the tools import fromscripts/ande2e/are not part of this check.tools/load.spec.tsnow fails on any plain JavaScript module added undertools/. I showed it failing on a probe file.Checked:
.mjsversions, and the library spec runs 4, all passing.🤖 Generated with Claude Code