Repository navigation
Spec 013 T024: CLAUDE.md's rule for new service code - #653
Merged
Merged
Conversation
Both rules T024 waited for emerged in T023: - New code under tools/ is TypeScript. A plain .mjs would be loaded by the type check unchecked, and tools/load.spec.ts fails on one. - A new entry point is loaded under Node by tools/load.spec.ts: a module in a service directory as it is, a new service directory by joining SERVICES, and a script that does its work when loaded by joining RUN_ON_LOAD, so it is checked without being run. From T023's final review: the no-plain-JavaScript check matches any case and .jsx, and excludes only the one generated bundle rather than any file with its name (each shown failing on a probe); three comments name the .ts specs they point at. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…y's top-level modules (from the review) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec 013, T024.
The rules T024 waited for, both of which emerged in T023, are now in
CLAUDE.md:tools/is TypeScript. A plain.mjswould be loaded by the type check without being checked, sotools/load.spec.tsfails on one.tools/load.spec.ts:SERVICES;RUN_ON_LOAD, so it is checked without being run.From T023's final review (#652):
.js,.mjs,.cjsand.jsxin any letter case.p.JS,q.jsx, and aharness.bundle.jselsewhere..tsspecs they point at.🤖 Generated with Claude Code