Repository navigation
Spec 013 T023: query-search and species-search, in TypeScript - #651
Merged
Merged
Conversation
Batch 6 of the .mjs specs: tools/content-node's query-search and species-search, 151 errors with checkJs on. Each is now a .ts spec, typed and held at zero on both counts. - Their stand-in Solr and report services typed once each: the Solr form as [name, value] pairs, the reports as what reached the service. - Requests and reports are read through helpers that throw when there is none; the targets report is found or the test fails. - species-search's stand-in graph shares its read count and outage flag through a typed view of globalThis, as citation.spec already does. - A facet query with its lists left out is cast with the reason (the endpoint fills them; an absent list reads as empty). Also from batch 5's review: spec 010's tasks name parity.spec.ts. Same 31 tests as the .mjs versions, all passing; types, lint (1,329) and dead code (131) unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec 013, T023, batch 6 of the
.mjsspecs. Batch 5 was #650.What changed.
tools/content-node's query-search and species-search are converted. They held 151 errors withcheckJson. Each is now a typed.tsspec, held at zero on both counts.How:
[name, value]pairs, and the reports as what reached the service.globalThis, as citation.spec already does.Also, from batch 5's review: spec 010's tasks name
parity.spec.ts.Checked:
.mjsversions and the new.tsones each run the same 31 tests, all passing.🤖 Generated with Claude Code