Repository navigation
Spec 013 T023: icon, facet-query and the Java parity spec, in TypeScript - #650
Merged
Merged
Conversation
Batch 5 of the .mjs specs: tools/content-node's icon and facet-query, and tools/java-parity's parity spec -- 151 errors with checkJs on. Each is now a .ts spec, typed and held at zero on both counts. - The stand-in Solr in icon and facet-query typed as in batch 4. - searchEntry's answer is a plain record, so its fields are read by name; each such read was rewritten at exactly the position the compiler named, and nowhere else. - facet-query passes facetQueryParams queries with some lists left out. The endpoint always fills them, and the function reads an absent list as an empty one, so a typed helper says so rather than filling them in. - The parity spec's stub servers and their tables are typed, the candidate's name a constant of its own; reports are read through a helper that throws when there is no result; the stub's early returns are explicit. Same 59 tests as the .mjs versions, all passing; types, lint (1,329) and dead code (131) unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec 013, T023, batch 5 of the
.mjsspecs. Batch 4 was #649.What changed. Three specs are converted:
tools/content-node's icon and facet-query, andtools/java-parity's parity spec. They held 151 errors withcheckJson. Each is now a typed.tsspec, held at zero on both counts.How:
searchEntry's answer is a plain record, so its fields are read by name. Each such read was rewritten at exactly the position the compiler named, and nowhere else.facetQueryParamsqueries with some lists left out. The endpoint always fills them, and the function reads an absent list as an empty one, so a typed helper says so rather than filling them in.Checked:
.mjsversions and the new.tsones each run the same 59 tests, all passing.🤖 Generated with Claude Code