Repository navigation
Spec 013 T023: seven more content-service specs, in TypeScript - #649
Merged
Merged
Conversation
Batch 4 of the .mjs specs: contained-events, pathways-of, flag, query-attribute, discover, diagram-search and references-mapping -- 235 errors with checkJs on. Each is now a .ts spec, typed and held at zero on both counts. As before: servers and stand-in graphs typed, the parameters read by name declared, JSON answers read as the shape Java writes, recorded queries and requests read through helpers that throw when there is none. New here: - the stand-in Solr (pathways-of, flag, diagram-search) typed once: its form as [name, value] pairs, its URL never undefined; - discover reads schemaDataSet's answer through one typed view, since NON_EMPTY leaves fields out; - query-attribute maps its fixtures through a helper that fails when a node is not mapped, and asks for getters that must exist; - a test asserting a field is absent (diagram-search's fireworksSpecies) takes the first entry through a helper that throws when there is none, so an empty answer still fails as it did. Same 82 tests as the .mjs versions, all passing; types, lint (1,329) and dead code (131) unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec 013, T023, batch 4 of the
.mjsspecs. Batch 3 was #647.What changed. Seven content-service specs are converted: contained-events, pathways-of, flag, query-attribute, discover, diagram-search and references-mapping. They held 235 errors with
checkJson. Each is now a typed.tsspec, held at zero on both counts.As before:
New in this batch:
[name, value]pairs, and its URL neverundefined.schemaDataSet's answer through one typed view, sinceNON_EMPTYleaves fields out.fireworksSpecies) takes the first entry through a helper that throws when there is none, so an empty answer still fails, as it did before.Checked:
.mjsversions and the new.tsones each run the same 82 tests, all passing.🤖 Generated with Claude Code