Repository navigation
Spec 013 T023: eight more content-service specs, in TypeScript - #647
Merged
Merged
Conversation
Batch 3 of the .mjs specs: pathways-low, complexes, overview-export, schema-objects, orthology, query-attribute-endpoint, interactors-static and referrers -- 183 errors with checkJs on. Each is now a .ts spec, typed and held at zero on both counts, as batch 2's were: - the servers and stand-in graphs typed as before (Server and AddressInfo; the graph's read taking a cypher string and its parameters, with the parameters the tests read by name declared); - each JSON answer read as the shape Java writes; - "the last query asked" and "the nth query asked" throw when there is none, as indexing into nothing threw before, so none can pass on undefined; - tuple loops typed `as const`; body-less POSTs send no body, as before; - fixtures typed from what they feed (orthologyMap's found objects as GraphNode, the lazily loaded objects of the attribute endpoint). Same 103 tests as the .mjs versions, all passing; types, lint (1,329) and dead code (131) unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…he review) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec 013, T023, batch 3 of the
.mjsspecs. Batch 2 was #645.What changed. Eight content-service specs are converted: pathways-low, complexes, overview-export, schema-objects, orthology, query-attribute-endpoint, interactors-static and referrers. They held 183 errors with
checkJson. Each is now a typed.tsspec, held at zero on both counts.How they're typed, as batch 2's were:
ServerandAddressInfo. The graph'sreadtakes a cypher string and its parameters, with the parameters the tests read by name declared.undefined.as const. A POST with no body still sends none.orthologyMap's found objects asGraphNode, and the attribute endpoint's lazily loaded objects.Checked:
.mjsversions and the new.tsones each run the same 103 tests, all passing.🤖 Generated with Claude Code