Repository navigation
Adopt Spec Kit, with a constitution and a CLAUDE.md - #5
Merged
Merged
Conversation
Spec Kit 1.0.4 set up as reactome/WebsiteAngular has it (Claude integration, shell scripts, sequential feature numbers), so feature-sized work here goes specify -> plan -> tasks before code, with the specs in specs/. The constitution's principles each name what breaking them has already cost this exporter: output proven against the release's published biopax.zip by meaning (the port shipped with no comparison and far less content); the validator's reports read rather than its exit code; tests seen failing; one library for the release and the website; no use of production services; people's names kept out of the repository. CLAUDE.md carries the day-to-day guidance. Plan: issue #4. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- `mvn test` compiles no tests (the Kotlin plugin binds only compile), and ktlint is no gate (the lint stage never runs in CI, and the build's ktlint:format rewrites the sources first; main has violations). Both are now named as checks that do not work yet, in Principle II and in CLAUDE.md, and the quality gates say the first spec makes each real. - The coverage gap is stated as read from the code (WebsiteAngular spec 015 R9), not measured from output; species mode's duplicate sub-pathways are dropped as an inference. - The validator: the standalone 6.0.0 exits 0; this repository's own 5.1.0 call is never made. - Principle IV is the target, not the present; Principle V says plainly that the release's download directory is the one allowed source and the production services are not; Principle VI names its cost and its scope. - The workflow says what main's protection does and does not do; CLAUDE.md gains "This repository is public" and the single-PR-fix rule, as WebsiteAngular has them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first step of #4. It sets up Spec Kit so the exporter's work is specified before it is built, as in reactome/WebsiteAngular.
Contents:
.specify/holds the templates and scripts..claude/skills/holds the/speckit-*commands..specify/memory/constitution.md). Each principle names what breaking it has already cost this exporter:biopax.zip, by meaning;CLAUDE.md: day-to-day guidance. Use Spec Kit for feature-sized work, how to prove what is written, and what to check before pushing.No code changes.
Next: the first spec (
specs/001-…), covering what #4 describes: the library and command-line split, today's content, the mode andxml:basefixes, the comparison withbiopax.zip, and the validator in CI.From an adversarial review, which ran the checks rather than reading them:
mvn testcompiles no tests. The Kotlin plugin binds onlycompile, so the 42 tests insrc/testhave never run.ktlint:formatrewrites the sources first.mvn ktlint:checkon its own fails onmain.validateBioPAXFileis never called.The constitution and
CLAUDE.mdnow say so: the gates are what the first spec makes real, not checks to trust today. The rest of the review's points are corrected too:CLAUDE.mdgains "This repository is public".🤖 Generated with Claude Code