Skip to content

Delete dead per-module RCTBridge accessors (#59443) #59443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christophpurrer wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −168
Open

Delete dead per-module RCTBridge accessors (#59443) #59443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb6e0f5
Delete dead RCTCxxBridgeDelegate protocol (#59441)
christophpurrer Oct 28, 2026
01d6028
Delete dead per-module RCTBridge accessors (#59443)
christophpurrer Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/react-native/Libraries/AppDelegate/RCTRootViewFactory.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
#import <React/RCTUtils.h>
#import "RCTJSRuntimeConfiguratorProtocol.h"

@protocol RCTCxxBridgeDelegate;
@protocol RCTComponentViewFactoryComponentProvider;
@protocol RCTTurboModuleManagerDelegate;
@protocol RCTHostDelegate;
Expand Down
6 changes: 0 additions & 6 deletions packages/react-native/Libraries/Image/RCTImageStoreManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,6 @@

@end

@interface RCTBridge (RCTImageStoreManager)

@property (nonatomic, readonly) RCTImageStoreManager *imageStoreManager;

@end

@interface RCTBridgeProxy (RCTImageStoreManager)

@property (nonatomic, readonly) RCTImageStoreManager *imageStoreManager;
Expand Down
6 changes: 0 additions & 6 deletions packages/react-native/Libraries/Network/RCTNetworking.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,6 @@

@end

@interface RCTBridge (RCTNetworking)

@property (nonatomic, readonly) RCTNetworking *networking;

@end

@interface RCTBridgeProxy (RCTNetworking)

@property (nonatomic, readonly) RCTNetworking *networking;
Expand Down
6 changes: 0 additions & 6 deletions packages/react-native/React/CoreModules/RCTAccessibilityManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,6 @@ extern NSString *const RCTAccessibilityManagerDidUpdateMultiplierNotification; /

@end

@interface RCTBridge (RCTAccessibilityManager)

@property (nonatomic, readonly) RCTAccessibilityManager *accessibilityManager;

@end

@interface RCTBridgeProxy (RCTAccessibilityManager)

@property (nonatomic, readonly) RCTAccessibilityManager *accessibilityManager;
Expand Down
3 changes: 2 additions & 1 deletion packages/react-native/React/CoreModules/RCTDevMenu.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,8 @@ typedef NSString * (^RCTDevMenuItemTitleBlock)(void);
*/
@interface RCTBridge (RCTDevMenu)

@property (nonatomic, readonly) RCTDevMenu *devMenu;
@property (nonatomic, readonly) RCTDevMenu *devMenu __deprecated_msg(
"Access RCTDevMenu through the bridge proxy instead; this accessor will be removed.");

@end

Expand Down
6 changes: 0 additions & 6 deletions packages/react-native/React/CoreModules/RCTDevSettings.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,12 +142,6 @@ typedef void (^RCTConnectedHandler)(void);

@end

@interface RCTBridge (RCTDevSettings)

@property (nonatomic, readonly) RCTDevSettings *devSettings;

@end

@interface RCTBridgeProxy (RCTDevSettings)

@property (nonatomic, readonly) RCTDevSettings *devSettings;
Expand Down
6 changes: 0 additions & 6 deletions packages/react-native/React/CoreModules/RCTWebSocketModule.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,6 @@ RCT_EXTERN void RCTSetCustomSRWebSocketProvider(SRWebSocketProvider provider);

@end

@interface RCTBridge (RCTWebSocketModule)

- (RCTWebSocketModule *)webSocketModule;

@end

@interface RCTBridgeProxy (RCTWebSocketModule)

- (RCTWebSocketModule *)webSocketModule;
Expand Down
31 changes: 0 additions & 31 deletions packages/react-native/React/CxxBridge/RCTCxxBridgeDelegate.h
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions packages/react-native/React/Modules/RCTUIManager.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,15 +220,6 @@ - (void)invalidate

@end

@implementation RCTBridge (RCTUIManager)

- (RCTUIManager *)uiManager
{
return [self moduleForClass:[RCTUIManager class]];
}

@end

UIView *RCTPaperViewOrCurrentView(UIView *view)
{
if ([view respondsToSelector:@selector(paperView)]) {
Expand Down
24 changes: 0 additions & 24 deletions scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,10 @@ category RCTBridge(Inspector) {
public @property (assign, readonly) facebook::react::jsinspector_modern::HostTarget* inspectorTarget;
}

category RCTBridge(RCTAccessibilityManager) {
public @property (assign, readonly) RCTAccessibilityManager* accessibilityManager;
}

category RCTBridge(RCTDevMenu) {
public @property (assign, readonly) RCTDevMenu* devMenu;
}

category RCTBridge(RCTDevSettings) {
public @property (assign, readonly) RCTDevSettings* devSettings;
}

category RCTBridge(RCTEventDispatcher) {
public virtual id<RCTEventDispatcherProtocol> eventDispatcher();
}
Expand All @@ -30,14 +22,6 @@ category RCTBridge(RCTImageLoader) {
public @property (assign, readonly) RCTImageLoader* imageLoader;
}

category RCTBridge(RCTImageStoreManager) {
public @property (assign, readonly) RCTImageStoreManager* imageStoreManager;
}

category RCTBridge(RCTNetworking) {
public @property (assign, readonly) RCTNetworking* networking;
}

category RCTBridge(RCTSurfacePresenterStub) {
public virtual id<RCTSurfacePresenterStub> surfacePresenter();
public virtual void setSurfacePresenter:(id<RCTSurfacePresenterStub> presenter);
Expand All @@ -47,10 +31,6 @@ category RCTBridge(RCTUIManager) {
public @property (assign, readonly) RCTUIManager* uiManager;
}

category RCTBridge(RCTWebSocketModule) {
public virtual RCTWebSocketModule* webSocketModule();
}

category RCTBridgeProxy(Cxx) {
public @property (assign) std::shared_ptr<facebook::react::CallInvoker> jsCallInvoker;
}
Expand Down Expand Up @@ -2597,10 +2577,6 @@ protocol RCTCustomRefreshControlProtocol {
public @property (weak) UIScrollView* scrollView;
}

protocol RCTCxxBridgeDelegate : public RCTBridgeDelegate {
public virtual std::unique_ptr<facebook::react::JSExecutorFactory> jsExecutorFactoryForBridge:(RCTBridge* bridge);
}

protocol RCTDebuggingOverlayViewProtocol : public NSObject {
public virtual void clearElementsHighlights();
public virtual void highlightElements:(const NSArray* elements);
Expand Down
24 changes: 0 additions & 24 deletions scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,10 @@ category RCTBridge(Inspector) {
public @property (assign, readonly) facebook::react::jsinspector_modern::HostTarget* inspectorTarget;
}

category RCTBridge(RCTAccessibilityManager) {
public @property (assign, readonly) RCTAccessibilityManager* accessibilityManager;
}

category RCTBridge(RCTDevMenu) {
public @property (assign, readonly) RCTDevMenu* devMenu;
}

category RCTBridge(RCTDevSettings) {
public @property (assign, readonly) RCTDevSettings* devSettings;
}

category RCTBridge(RCTEventDispatcher) {
public virtual id<RCTEventDispatcherProtocol> eventDispatcher();
}
Expand All @@ -30,14 +22,6 @@ category RCTBridge(RCTImageLoader) {
public @property (assign, readonly) RCTImageLoader* imageLoader;
}

category RCTBridge(RCTImageStoreManager) {
public @property (assign, readonly) RCTImageStoreManager* imageStoreManager;
}

category RCTBridge(RCTNetworking) {
public @property (assign, readonly) RCTNetworking* networking;
}

category RCTBridge(RCTSurfacePresenterStub) {
public virtual id<RCTSurfacePresenterStub> surfacePresenter();
public virtual void setSurfacePresenter:(id<RCTSurfacePresenterStub> presenter);
Expand All @@ -47,10 +31,6 @@ category RCTBridge(RCTUIManager) {
public @property (assign, readonly) RCTUIManager* uiManager;
}

category RCTBridge(RCTWebSocketModule) {
public virtual RCTWebSocketModule* webSocketModule();
}

category RCTBridgeProxy(Cxx) {
public @property (assign) std::shared_ptr<facebook::react::CallInvoker> jsCallInvoker;
}
Expand Down Expand Up @@ -2659,10 +2639,6 @@ protocol RCTCustomRefreshControlProtocol {
public @property (weak) UIScrollView* scrollView;
}

protocol RCTCxxBridgeDelegate : public RCTBridgeDelegate {
public virtual std::unique_ptr<facebook::react::JSExecutorFactory> jsExecutorFactoryForBridge:(RCTBridge* bridge);
}

protocol RCTDebuggingOverlayViewProtocol : public NSObject {
public virtual void clearElementsHighlights();
public virtual void highlightElements:(const NSArray* elements);
Expand Down
24 changes: 0 additions & 24 deletions scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,10 @@ category RCTBridge(Inspector) {
public @property (assign, readonly) facebook::react::jsinspector_modern::HostTarget* inspectorTarget;
}

category RCTBridge(RCTAccessibilityManager) {
public @property (assign, readonly) RCTAccessibilityManager* accessibilityManager;
}

category RCTBridge(RCTDevMenu) {
public @property (assign, readonly) RCTDevMenu* devMenu;
}

category RCTBridge(RCTDevSettings) {
public @property (assign, readonly) RCTDevSettings* devSettings;
}

category RCTBridge(RCTEventDispatcher) {
public virtual id<RCTEventDispatcherProtocol> eventDispatcher();
}
Expand All @@ -30,14 +22,6 @@ category RCTBridge(RCTImageLoader) {
public @property (assign, readonly) RCTImageLoader* imageLoader;
}

category RCTBridge(RCTImageStoreManager) {
public @property (assign, readonly) RCTImageStoreManager* imageStoreManager;
}

category RCTBridge(RCTNetworking) {
public @property (assign, readonly) RCTNetworking* networking;
}

category RCTBridge(RCTSurfacePresenterStub) {
public virtual id<RCTSurfacePresenterStub> surfacePresenter();
public virtual void setSurfacePresenter:(id<RCTSurfacePresenterStub> presenter);
Expand All @@ -47,10 +31,6 @@ category RCTBridge(RCTUIManager) {
public @property (assign, readonly) RCTUIManager* uiManager;
}

category RCTBridge(RCTWebSocketModule) {
public virtual RCTWebSocketModule* webSocketModule();
}

category RCTBridgeProxy(Cxx) {
public @property (assign) std::shared_ptr<facebook::react::CallInvoker> jsCallInvoker;
}
Expand Down Expand Up @@ -2590,10 +2570,6 @@ protocol RCTCustomRefreshControlProtocol {
public @property (weak) UIScrollView* scrollView;
}

protocol RCTCxxBridgeDelegate : public RCTBridgeDelegate {
public virtual std::unique_ptr<facebook::react::JSExecutorFactory> jsExecutorFactoryForBridge:(RCTBridge* bridge);
}

protocol RCTDebuggingOverlayViewProtocol : public NSObject {
public virtual void clearElementsHighlights();
public virtual void highlightElements:(const NSArray* elements);
Expand Down
24 changes: 0 additions & 24 deletions scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,10 @@ category RCTBridge(Inspector) {
public @property (assign, readonly) facebook::react::jsinspector_modern::HostTarget* inspectorTarget;
}

category RCTBridge(RCTAccessibilityManager) {
public @property (assign, readonly) RCTAccessibilityManager* accessibilityManager;
}

category RCTBridge(RCTDevMenu) {
public @property (assign, readonly) RCTDevMenu* devMenu;
}

category RCTBridge(RCTDevSettings) {
public @property (assign, readonly) RCTDevSettings* devSettings;
}

category RCTBridge(RCTEventDispatcher) {
public virtual id<RCTEventDispatcherProtocol> eventDispatcher();
}
Expand All @@ -30,14 +22,6 @@ category RCTBridge(RCTImageLoader) {
public @property (assign, readonly) RCTImageLoader* imageLoader;
}

category RCTBridge(RCTImageStoreManager) {
public @property (assign, readonly) RCTImageStoreManager* imageStoreManager;
}

category RCTBridge(RCTNetworking) {
public @property (assign, readonly) RCTNetworking* networking;
}

category RCTBridge(RCTSurfacePresenterStub) {
public virtual id<RCTSurfacePresenterStub> surfacePresenter();
public virtual void setSurfacePresenter:(id<RCTSurfacePresenterStub> presenter);
Expand All @@ -47,10 +31,6 @@ category RCTBridge(RCTUIManager) {
public @property (assign, readonly) RCTUIManager* uiManager;
}

category RCTBridge(RCTWebSocketModule) {
public virtual RCTWebSocketModule* webSocketModule();
}

category RCTBridgeProxy(Cxx) {
public @property (assign) std::shared_ptr<facebook::react::CallInvoker> jsCallInvoker;
}
Expand Down Expand Up @@ -2597,10 +2577,6 @@ protocol RCTCustomRefreshControlProtocol {
public @property (weak) UIScrollView* scrollView;
}

protocol RCTCxxBridgeDelegate : public RCTBridgeDelegate {
public virtual std::unique_ptr<facebook::react::JSExecutorFactory> jsExecutorFactoryForBridge:(RCTBridge* bridge);
}

protocol RCTDebuggingOverlayViewProtocol : public NSObject {
public virtual void clearElementsHighlights();
public virtual void highlightElements:(const NSArray* elements);
Expand Down
Loading