Repository navigation
Delete dead per-module RCTBridge accessors (#59443) - #59443
Open
christophpurrer wants to merge 2 commits into
Open
christophpurrer wants to merge 2 commits into
christophpurrer wants to merge 2 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127294783. |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 24, 2026
Summary: Pull Request resolved: react#59443 Five module accessors on `RCTBridge` (`networking`, `webSocketModule`, `accessibilityManager`, `devSettings`, `imageStoreManager`) have no callers. Delete the bridge-side declarations and the last bridge-side implementation (`uiManager`, whose proxy implementation stays). Deprecate `devMenu`, which external clients still use. Changelog: [iOS][Removed] - Remove unused per-module `RCTBridge` accessors Differential Revision: D127294783
meta-codesync
Bot
changed the title
christophpurrer
force-pushed
the
export-D127294783
branch
from
October 24, 2026 03:22
203f9e1 to
62567ae
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 24, 2026
Summary: Pull Request resolved: react#59443 Five module accessors on `RCTBridge` (`networking`, `webSocketModule`, `accessibilityManager`, `devSettings`, `imageStoreManager`) have no callers. Delete the bridge-side declarations and the last bridge-side implementation (`uiManager`, whose proxy implementation stays). Deprecate `devMenu`, which external clients still use. Changelog: [iOS][Removed] - Remove unused per-module `RCTBridge` accessors Differential Revision: D127294783
christophpurrer
force-pushed
the
export-D127294783
branch
from
October 24, 2026 03:50
62567ae to
8e62f54
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 24, 2026
Summary: Pull Request resolved: react#59443 Five module accessors on `RCTBridge` (`networking`, `webSocketModule`, `accessibilityManager`, `devSettings`, `imageStoreManager`) have no callers. Delete the bridge-side declarations and the last bridge-side implementation (`uiManager`, whose proxy implementation stays). Deprecate `devMenu`, which external clients still use. Changelog: [iOS][Removed] - Remove unused per-module `RCTBridge` accessors Differential Revision: D127294783
christophpurrer
force-pushed
the
export-D127294783
branch
from
October 24, 2026 15:16
8e62f54 to
207c502
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
Summary: Pull Request resolved: react#59443 Five module accessors on `RCTBridge` (`networking`, `webSocketModule`, `accessibilityManager`, `devSettings`, `imageStoreManager`) have no callers. Delete the bridge-side declarations and the last bridge-side implementation (`uiManager`, whose proxy implementation stays). Deprecate `devMenu`, which external clients still use. Changelog: [iOS][Removed] - Remove unused per-module `RCTBridge` accessors Reviewed By: cipolleschi Differential Revision: D127294783
christophpurrer
force-pushed
the
export-D127294783
branch
from
October 27, 2026 14:18
207c502 to
6f7fd65
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
Summary: Five module accessors on `RCTBridge` (`networking`, `webSocketModule`, `accessibilityManager`, `devSettings`, `imageStoreManager`) have no callers. Delete the bridge-side declarations and the last bridge-side implementation (`uiManager`, whose proxy implementation stays). Deprecate `devMenu`, which external clients still use. Changelog: [iOS][Removed] - Remove unused per-module `RCTBridge` accessors Reviewed By: cipolleschi Differential Revision: D127294783
christophpurrer
force-pushed
the
export-D127294783
branch
from
October 27, 2026 22:16
6f7fd65 to
066b01a
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
Summary: Five module accessors on `RCTBridge` (`networking`, `webSocketModule`, `accessibilityManager`, `devSettings`, `imageStoreManager`) have no callers. Delete the bridge-side declarations and the last bridge-side implementation (`uiManager`, whose proxy implementation stays). Deprecate `devMenu`, which external clients still use. Changelog: [iOS][Removed] - Remove unused per-module `RCTBridge` accessors Reviewed By: cipolleschi Differential Revision: D127294783
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
Summary: Five module accessors on `RCTBridge` (`networking`, `webSocketModule`, `accessibilityManager`, `devSettings`, `imageStoreManager`) have no callers. Delete the bridge-side declarations and the last bridge-side implementation (`uiManager`, whose proxy implementation stays). Deprecate `devMenu`, which external clients still use. Changelog: [iOS][Removed] - Remove unused per-module `RCTBridge` accessors Reviewed By: cipolleschi Differential Revision: D127294783
christophpurrer
force-pushed
the
export-D127294783
branch
2 times, most recently
from
October 27, 2026 23:03
6389fd6 to
da583a6
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
Summary: Five module accessors on `RCTBridge` (`networking`, `webSocketModule`, `accessibilityManager`, `devSettings`, `imageStoreManager`) have no callers. Delete the bridge-side declarations and the last bridge-side implementation (`uiManager`, whose proxy implementation stays). Deprecate `devMenu`, which external clients still use. Changelog: [iOS][Removed] - Remove unused per-module `RCTBridge` accessors Reviewed By: cipolleschi Differential Revision: D127294783
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 28, 2026
Summary: Five module accessors on `RCTBridge` (`networking`, `webSocketModule`, `accessibilityManager`, `devSettings`, `imageStoreManager`) have no callers. Delete the bridge-side declarations and the last bridge-side implementation (`uiManager`, whose proxy implementation stays). Deprecate `devMenu`, which external clients still use. Changelog: [iOS][Removed] - Remove unused per-module `RCTBridge` accessors Reviewed By: cipolleschi Differential Revision: D127294783
christophpurrer
force-pushed
the
export-D127294783
branch
from
October 28, 2026 01:05
da583a6 to
74c0d9c
Compare
Visual regressionNo visual differences at android: no capture |
Summary: The C++ bridge delegate protocol has no implementers left: its only method served the removed `RCTCxxBridge`. Delete the header with its build entry, the stale forward declaration, and the unused imports. Changelog: [iOS][Removed] - Remove unused `RCTCxxBridgeDelegate` protocol Reviewed By: zeyap Differential Revision: D127294781
Summary: Five module accessors on `RCTBridge` (`networking`, `webSocketModule`, `accessibilityManager`, `devSettings`, `imageStoreManager`) have no callers. Delete the bridge-side declarations and the last bridge-side implementation (`uiManager`, whose proxy implementation stays). Deprecate `devMenu`, which external clients still use. Changelog: [iOS][Removed] - Remove unused per-module `RCTBridge` accessors Reviewed By: cipolleschi Differential Revision: D127294783
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 28, 2026
Summary: Five module accessors on `RCTBridge` (`networking`, `webSocketModule`, `accessibilityManager`, `devSettings`, `imageStoreManager`) have no callers. Delete the bridge-side declarations and the last bridge-side implementation (`uiManager`, whose proxy implementation stays). Deprecate `devMenu`, which external clients still use. Changelog: [iOS][Removed] - Remove unused per-module `RCTBridge` accessors Reviewed By: cipolleschi Differential Revision: D127294783
christophpurrer
force-pushed
the
export-D127294783
branch
2 times, most recently
from
October 28, 2026 14:45
d53f44a to
01d6028
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 28, 2026
Summary: Five module accessors on `RCTBridge` (`networking`, `webSocketModule`, `accessibilityManager`, `devSettings`, `imageStoreManager`) have no callers. Delete the bridge-side declarations and the last bridge-side implementation (`uiManager`, whose proxy implementation stays). Deprecate `devMenu`, which external clients still use. Changelog: [iOS][Removed] - Remove unused per-module `RCTBridge` accessors Reviewed By: cipolleschi Differential Revision: D127294783
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 28, 2026
Summary: Five module accessors on `RCTBridge` (`networking`, `webSocketModule`, `accessibilityManager`, `devSettings`, `imageStoreManager`) have no callers. Delete the bridge-side declarations and the last bridge-side implementation (`uiManager`, whose proxy implementation stays). Deprecate `devMenu`, which external clients still use. Changelog: [iOS][Removed] - Remove unused per-module `RCTBridge` accessors Reviewed By: cipolleschi Differential Revision: D127294783
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Five module accessors on
RCTBridge(networking,webSocketModule,accessibilityManager,devSettings,imageStoreManager) have no callers. Delete the bridge-side declarations and the last bridge-side implementation (uiManager, whose proxy implementation stays). DeprecatedevMenu, which external clients still use.Changelog:
[iOS][Removed] - Remove unused per-module
RCTBridgeaccessorsReviewed By: cipolleschi
Differential Revision: D127294783