Skip to content

Improve behaviour on blur #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rolftimmermans wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −0
Open

Improve behaviour on blur #255

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
328dec9
Improve behaviour on blur
rolftimmermans Dec 20, 2017
69890f4
Update Select.jsx
rolftimmermans Dec 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Select.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,11 @@ export default class Select extends React.Component {
label: this.getLabelFromOption(firstOption),
},
];

/* Close dropdown so the unfiltering caused by fireChange()
does not cause the dropdown to animate and expand just
before closing again. */
this.setOpenState(false);
Copy link
Copy Markdown
Contributor

@yutingzhao1991 yutingzhao1991 Dec 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this works? There is already has this.setOpenState(false); at line 397.

this.fireChange(value);
}
}
Expand Down