Improve behaviour on blur#255
Open
rolftimmermans wants to merge 2 commits intoreact-component:masterfrom
Open
Conversation
I'm using something similar to the following code. This is one of the examples from https://ant.design/components/select/ ``` <Select showSearch style={{ width: 200 }} placeholder="Select a person" optionFilterProp="children" onChange={handleChange} onFocus={handleFocus} onBlur={handleBlur} filterOption={(input, option) => option.props.children.toLowerCase().indexOf(input.toLowerCase()) >= 0} > <Option value="jack">Jack</Option> <Option value="lucy">Lucy</Option> <Option value="tom">Tom</Option> </Select> ``` When typing "jack" and then pressing TAB, the dropdown box briefly expands just before closing again. This patch fixes that behaviour by setting the open state to closed just before firing the change, instead of afterwards.
Codecov Report
@@ Coverage Diff @@
## master #255 +/- ##
==========================================
+ Coverage 98.95% 98.95% +<.01%
==========================================
Files 8 8
Lines 287 288 +1
Branches 81 82 +1
==========================================
+ Hits 284 285 +1
Misses 3 3
Continue to review full report at Codecov.
|
Member
|
Thanks, I'v tried fix this behavior too, but can't reproduce it in test, can you write a test? |
| /* Close dropdown so the unfiltering caused by fireChange() | ||
| does not cause the dropdown to animate and expand just | ||
| before closing again. */ | ||
| this.setOpenState(false); |
Contributor
There was a problem hiding this comment.
Is this works? There is already has this.setOpenState(false); at line 397.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using something similar to the following code. This is one of the examples from https://ant.design/components/select/
When typing "jack" and then pressing TAB, the dropdown box briefly expands just before closing again.
This patch fixes that behaviour by setting the open state to closed just before firing the change, instead of afterwards.