Add the ability to pass through the keepalive configuration option#86
Merged
marcelolx merged 2 commits intorails:mainfrom Apr 28, 2025
Merged
Add the ability to pass through the keepalive configuration option#86marcelolx merged 2 commits intorails:mainfrom
marcelolx merged 2 commits intorails:mainfrom
Conversation
Contributor
Author
|
CI needs some fixing :) |
Merged
Collaborator
Contributor
Author
|
Hi @marcelolx, all done :) |
Contributor
Author
|
Hi @marcelolx, would you mind cutting a new release with this fix in it? :) |
Collaborator
|
Done @brendon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a few concerns:
fetchfor many options. Why not just omit passing them if they're not passed in?contentTypeandheadersas needed.The solution to those is a much larger change, so for now just allowing
keepalivethrough solves my immediate use-case.Closes #85