Fix configure warning showing binary path instead of directory for PATH#14459
Open
Fix configure warning showing binary path instead of directory for PATH#14459
Conversation
The "Please ensure that <path> is in your path" warnings emitted when the configure script cannot create a symlink were showing the path to the quarto binary itself, but PATH expects a directory. Use config.directoryInfo.bin so the warning reports the directory users should add to PATH. Closes #14426
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14426
When the
configurescript cannot create aquartosymlink in auser-writable bin path, it falls back to printing:
The interpolated path was
join(config.directoryInfo.bin, "quarto")— i.e.the binary itself (
.../package/dist/bin/quarto). SincePATHexpects adirectory, the suggested path was always wrong: copy-pasting it into
PATHwould never work.Use
config.directoryInfo.bindirectly so the warning prints thedirectory the developer actually needs to add to
PATH.Reported by @wlatendresse.