Skip to content

Arm backend: Fix semihosting CLI operand checks #24508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bdemirb wants to merge 2 commits into
base: main
Choose a base branch
from
+18 −6
Open

Arm backend: Fix semihosting CLI operand checks #24508

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a67e7d4
Arm backend: Fix semihosting CLI operand checks
bdemirb Nov 2, 2026
cd92417
Merge branch 'main' into unstack-1384796
bdemirb Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions examples/arm/executor_runner/arm_executor_runner.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1478,8 +1478,8 @@ int main(int argc, const char* argv[]) {
}
#endif
ET_LOG(Info, " %s", argv[0]);
for (int i = 1; i + 1 < argc; i += 2) {
ET_LOG(Info, " %s %s", argv[i], argv[i + 1]);
for (int i = 1; i < argc; i++) {
ET_LOG(Info, " %s", argv[i]);
}
#else
(void)argc;
Expand Down Expand Up @@ -1508,10 +1508,14 @@ int main(int argc, const char* argv[]) {
input_file_allocation_pool_size, input_file_allocation_pool);

/* parse input parameters */
for (int i = 0; i < argc; i++) {
for (int i = 1; i < argc; i++) {
if (std::strcmp(argv[i], "-i") == 0) {
if (++i >= argc || argv[i] == nullptr) {
ET_LOG(Fatal, "Missing value for -i");
return 1;
}
// input file, read the data into memory
const char* input_tensor_filename = argv[++i];
const char* input_tensor_filename = argv[i];
const printf_size_t nbr_inputs = input_buffers.size() + 1;
ET_LOG(
Info,
Expand All @@ -1531,7 +1535,11 @@ int main(int argc, const char* argv[]) {
input_buffers.push_back(std::make_pair(buffer, buffer_size));
ctx.input_filenames.push_back(input_tensor_filename);
} else if (std::strcmp(argv[i], "-m") == 0) {
const char* pte_filename = argv[++i];
if (++i >= argc || argv[i] == nullptr) {
ET_LOG(Fatal, "Missing value for -m");
return 1;
}
const char* pte_filename = argv[i];
ET_LOG(Info, "Reading pte model from file %s", pte_filename);
auto [buffer, buffer_size] =
read_binary_file(pte_filename, ctx.input_file_allocator.value());
Expand All @@ -1543,8 +1551,12 @@ int main(int argc, const char* argv[]) {
model_data = reinterpret_cast<const uint8_t*>(buffer);
model_size = buffer_size;
} else if (std::strcmp(argv[i], "-o") == 0) {
if (++i >= argc || argv[i] == nullptr) {
ET_LOG(Fatal, "Missing value for -o");
return 1;
}
// store the base filename to write output to.
ctx.output_basename = argv[++i];
ctx.output_basename = argv[i];
} else if (std::strcmp(argv[i], "--server_mode") == 0) {
if (++i >= argc) {
ET_LOG(Fatal, "--server_mode requires true or false");
Expand Down
Loading