Skip to content

Arm backend: Fix semihosting CLI operand checks - #24508

Open
bdemirb wants to merge 2 commits into
pytorch:mainfrom
bdemirb:unstack-1384796
Open

bdemirb wants to merge 2 commits into
pytorch:mainfrom
bdemirb:unstack-1384796

Conversation

@bdemirb

@bdemirb bdemirb commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Guard -i, -m, and -o before consuming argv[++i].
Avoid unsafe paired argument logging in semihosting mode.
Change-Id: I908a1d111da41fa0e7dcb42e2b03dbb97229416d

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

Guard -i, -m, and -o before consuming argv[++i].

Avoid unsafe paired argument logging in semihosting mode.

Signed-off-by: Baris Demir <baris.demir@arm.com>
Change-Id: I908a1d111da41fa0e7dcb42e2b03dbb97229416d
@pytorch-bot

pytorch-bot Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24508

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 39 Pending, 2 Unrelated Failures

As of commit cd92417 with merge base 7da27ca (image):

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 3, 2026
@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Nov 3, 2026
@bdemirb

bdemirb commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator Author

@pytorchbot label "partner: arm"

@pytorch-bot pytorch-bot Bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Nov 3, 2026
@bdemirb

bdemirb commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator Author

@pytorchbot label "release notes: arm"

@pytorch-bot pytorch-bot Bot added the release notes: arm Changes to the ARM backend delegate label Nov 3, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants