Skip to content

Remove unused exported tensor constants after Cortex-M lowering - #22862

Draft
rascani wants to merge 1 commit into
gh/rascani/44/headfrom
gh/rascani/45/head
Draft

rascani wants to merge 1 commit into
gh/rascani/44/headfrom
gh/rascani/45/head

Conversation

@rascani

@rascani rascani commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Cortex-M layout conversion leaves original constant placeholders that FX dead-code elimination preserves. Add a separate RemoveUnusedConstantsPass to retire unused input specs and storage in linear time. Include it after constant lifting in both default pass lists, after padding fusion and scratch sizing.

Lift constants exactly once through the pass list before pruning, avoiding generated buffer-name collisions. Remove the unconditional final lifting call: explicit custom lists define the complete pipeline and can select no cleanup, lifting only, or lifting followed by pruning. The small lifting adapter makes the existing utility usable by the standard ExportedProgram pass runner.

Preserve user inputs, mutation and gradient targets, preserved module-call signatures, and state shared with other entry points. The existing EXIR pass and other backend defaults remain unchanged. Eleven focused Python tests passed, including buffer-name collision and all three custom-list behaviors.

Authored with AI assistance from Codex.

[ghstack-poisoned]
@rascani

rascani commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

@pytorch-bot

pytorch-bot Bot commented Sep 15, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22862

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job

As of commit 7bc14d3 with merge base 026ca3f (image):

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant