Conversation
Contributor
Author
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22862
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled JobAs of commit 7bc14d3 with merge base 026ca3f ( CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cortex-M layout conversion leaves original constant placeholders that FX dead-code elimination preserves. Add a separate RemoveUnusedConstantsPass to retire unused input specs and storage in linear time. Include it after constant lifting in both default pass lists, after padding fusion and scratch sizing.
Lift constants exactly once through the pass list before pruning, avoiding generated buffer-name collisions. Remove the unconditional final lifting call: explicit custom lists define the complete pipeline and can select no cleanup, lifting only, or lifting followed by pruning. The small lifting adapter makes the existing utility usable by the standard ExportedProgram pass runner.
Preserve user inputs, mutation and gradient targets, preserved module-call signatures, and state shared with other entry points. The existing EXIR pass and other backend defaults remain unchanged. Eleven focused Python tests passed, including buffer-name collision and all three custom-list behaviors.
Authored with AI assistance from Codex.