Conversation
Contributor
Author
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22861
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4859b8e with merge base 026ca3f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicit SAME padding adds an int8 pad operation before convolution. Fuse supported zero-filled SAME_UPPER padding into regular and depthwise Cortex-M operators in both layout pipelines. Preserve shared pad outputs and keep the unsupported MVE 1xN case explicit. Include the MLPerf zero-pad expectations with this change.
Run FuseConvPaddingPass after dialect conversion and before scratch sizing. In the explicit-layout pipeline, propagate layouts before canonicalizing singleton permutations into views, which would hide the padding pattern. One cleanup/canonicalization pair suffices.
Validate four-value padding geometry at export time and use the planned output dimensions for trailing padding. Runtime uses the existing argument validation with support for either two or four padding values; it does not recalculate padding geometry.
Targeted Python and M55 FVP tests cover both layouts, shared pad outputs, regular/grouped/depthwise convolution and the unsupported 1xN fallback. Independent review checked the runtime-check removal and the layout ordering.
Authored with AI assistance from Codex.