Skip to content

gh-160986: Fix flaky test_popping_python_frame_is_not_native #161073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asvetlov merged 2 commits into from
Nov 2, 2026
+8 −0
Merged

gh-160986: Fix flaky test_popping_python_frame_is_not_native #161073

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aaa31b9
gh-160986: Fix flaky test_popping_python_frame_is_not_native
asvetlov Nov 1, 2026
2e57778
Reuse _get_stack_trace_with_retry() to wait for leaf()
asvetlov Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Lib/test/test_external_inspection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2041,6 +2041,14 @@ def leaf(depth):
except RuntimeError:
continue
break
# The unwinder can attach before the main loop starts.
_get_stack_trace_with_retry(
unwinder,
condition=lambda trace: trace[0].threads and any(
frame.funcname == "leaf"
for frame in trace[0].threads[0].frame_info
),
)
samples = 0
for _ in range(10_000):
try:
Expand Down
Loading