Repository navigation
gh-160986: Fix flaky test_popping_python_frame_is_not_native - #161073
Merged
Merged
Conversation
The unwinder can attach before the target process enters its main loop, so on slow builds (e.g. UBSan) all 10,000 samples could be taken before leaf() runs. Wait until leaf() shows up in a sample before counting. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
@vstinner @pablogsal I've stuck with this CI error recently when I was working on another issue. |
NekoAsakura
reviewed
Nov 2, 2026
NekoAsakura
left a comment
NekoAsakura
left a comment
Member
There was a problem hiding this comment.
LGTM. Nit: _get_stack_trace_with_retry(unwinder, condition=...) already does the waiting, so you may reuse it to keep the change minimal and get the last error in the timeout message.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
@NekoAsakura thanks, the suggestion is applied |
Contributor
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The remote unwinder can attach to the child process while it is still in interpreter startup, before it enters the
while True: leaf(300)loop. On slow builds the fixed window of 10,000 samples can finish beforeleaf()ever runs, so the test fails withAssertionError: 0 not greater than 1000(seen on buildbots and on the UBSan GHA job, e.g. https://github.com/python/cpython/actions/runs/41240245374/job/124652687585).The test now waits (up to
SHORT_TIMEOUT) until a sample containsleafbefore starting the counted sampling loop. The sampling logic is factored into a small local helper so the wait and the counted loop share it. The assertion that a poppingleafframe is never reported as<native>is unchanged.Supersedes the closed gh-160990. Test-only change, so no NEWS entry.
🤖 Generated with Claude Code