Skip to content

Add deprecation warning for irradiance.king #2783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cbcrespo wants to merge 3 commits into
base: main
Choose a base branch
from
+6 −0
Open

Add deprecation warning for irradiance.king #2783

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3780f37
Add deprecation warning for pvlib.irradiance.king
cbcrespo Jun 9, 2026
2ea4616
Correct deprecation version
cbcrespo Jun 15, 2026
b8d9a2c
Merge branch 'main' into king-deprecation
cbcrespo Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pvlib/irradiance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -989,6 +989,12 @@ def reindl(surface_tilt, surface_azimuth, dhi, dni, ghi, dni_extra,
return sky_diffuse


@deprecated(
since="0.15.2",
removal="",

@AdamRJensen AdamRJensen Jun 19, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
removal="",
removal="0.17.0",

name="pvlib.irradiance.king",
alternative="other diffuse transposition models in pvlib.irradiance",
)
def king(surface_tilt, dhi, ghi, solar_zenith):
'''
Determine diffuse irradiance from the sky on a tilted surface using
Expand Down
Loading