Skip to content

Add deprecation warning for irradiance.king#2783

Open
cbcrespo wants to merge 3 commits into
pvlib:mainfrom
cbcrespo:king-deprecation
Open

Add deprecation warning for irradiance.king#2783
cbcrespo wants to merge 3 commits into
pvlib:mainfrom
cbcrespo:king-deprecation

Conversation

@cbcrespo

Copy link
Copy Markdown
Contributor
  • Closes irradiance.king documentation and output naming is wrong #2636
  • I am familiar with the contributing guidelines
  • I attest that all AI-generated material has been vetted for accuracy and is in compliance with the pvlib license
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

@kandersolar kandersolar added this to the v0.15.3 milestone Jun 18, 2026
@kandersolar kandersolar added the deprecation Use for issues and PRs which involve deprecations label Jun 18, 2026
@kandersolar

Copy link
Copy Markdown
Member

Some minor edits to the tests are needed in order to prevent cluttering the CI output:

https://github.com/pvlib/pvlib-python/actions/runs/27539135408/job/82221477466?pr=2783#step:9:84

pytest offers a way to ensure that warnings are emitted while also suppressing them from the logs. Check #1401 for an example of how to use it.

Comment thread pvlib/irradiance.py

@deprecated(
since="0.15.2",
removal="",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
removal="",
removal="0.17.0",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api deprecation Use for issues and PRs which involve deprecations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

irradiance.king documentation and output naming is wrong

3 participants