Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions scripts/reviewers/copilot.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,14 @@
]
},
"closed_badges": [],
"labels": ["changes:", "review findings:", "findings:", "open findings remain:"],
"finding_lists": ["review findings:", "open findings remain:"],
"labels": [
"changes:",
"review findings:",
"findings:",
"open findings remain:",
"unresolved findings:"
],
"finding_lists": ["review findings:", "open findings remain:", "unresolved findings:"],
"effort": "review effort(?: level)?:? *(?:default *\\( *(?P<default>lite|balanced|max) *\\)|(?P<level>lite|balanced|max))",
"table_header": "file",
"discussion_link": "#discussion_r(?P<id>\\d+)$"
Expand Down
12 changes: 12 additions & 0 deletions tests/test_pr_review_copilot.py
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,18 @@ def test_a_findings_list_longer_than_the_threads_is_unthreaded(self) -> None:
)
self.assertEqual(1, found.unthreaded)

def test_each_top_level_findings_list_spelling_is_placed_and_counted(self) -> None:
for label in ("Review findings:", "Open findings remain:", "Unresolved findings:"):
with self.subTest(label=label):
listed = f"**{label}**\n- P1 moderate: one.\n- P2 nit: two.\n- P2 nit: three."
found = adapter.read(
body(sections=f"{open_section()}\n\n{listed}\n\n{what_changed()}"),
threads=("101", "102"),
)
self.assertEqual(1, found.unthreaded)
self.assertEqual((), found.notes)
self.assertEqual((), found.unplaced)

def test_a_nested_back_reference_is_not_an_entry(self) -> None:
nested = open_section().replace(
"\u00b7 New\n- ", "\u00b7 New\n - see [earlier](#discussion_r999)\n- ", 1
Expand Down
Loading