Repository navigation
Conversation
## Summary Copilot's review overview now introduces its remaining findings under an `Unresolved findings:` label. The Copilot reader in `scripts/reviewers/copilot.json` listed that spelling in neither `labels` nor `finding_lists`. As a result, `pr_review.py status` reported the part as unplaced, and a finding that appeared only in the body was not counted as `unthreaded`. ## Changes - Add `unresolved findings:` to both `labels` and `finding_lists`, the same way `open findings remain:` is listed. Adding it to `labels` alone, which is what #3513 proposed, would only silence the notice. The body-only finding would still be missed, because `finding_lists` is what counts listed items against linked threads. - Add one test that runs each top-level finding-list spelling through a constructed body. Each case asserts one unthreaded finding, no notes, and nothing unplaced. Before the fix, the test failed only on the new spelling, with `unthreaded` at 0 where 1 was expected. ## Verification - The full suite passes under `uv run --no-project --with-requirements tests/requirements.txt python -m unittest discover -s tests`: 3037 tests OK, 7 skipped. - The hub's `.husky/pre-commit` gates pass: ruff format and lint, mypy, the prose gate, and eol. - A local strict review ran at the `frontier` tier over this diff with zero findings. It is recorded as `agent-skill` against `develop`. Refs #3513, which the promotion pull request closes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified, and all reviewed changes have regression coverage.
No open issues 🎉
What changed in this PR
Promotes the Copilot Reader’s Unresolved findings: vocabulary update to main, ensuring those findings are recognized, counted, and associated with review threads.
Changes:
- Registers
unresolved findings:as a recognized label and finding-list pattern. - Adds parameterized regression coverage for all supported top-level finding-list spellings.
| File | Description |
|---|---|
tests/test_pr_review_copilot.py |
Verifies placement and unthreaded-finding counting for each supported finding-list spelling. |
scripts/reviewers/copilot.json |
Registers the unresolved-findings label for recognition and counting. |
Review effort: Lite
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3515 +/- ##
=======================================
Coverage 81.54% 81.54%
=======================================
Files 26 26
Lines 8918 8918
=======================================
Hits 7272 7272
Misses 1646 1646
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This promotes #3514 to
main. That change teaches the Copilot reader theUnresolved findings:label in both itslabelsandfinding_lists, so a finding listed there is placed and counted against the linked threads.Closes #3513
🤖 Generated with Claude Code