Repository navigation
Teach the Copilot Reader the Unresolved Findings Label - #3514
Conversation
Copilot's overview now introduces its remaining findings under an "Unresolved findings:" label, which the reader listed in neither its labels nor its finding lists, so the part read as unplaced and a finding present only in the body went uncounted as unthreaded. Add the spelling to both lists, as "open findings remain:" is, with a case per top-level finding-list spelling built from a constructed body. Closes #3513 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
A recorded local strict-review pass covers head |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
There was a problem hiding this comment.
🟢 Approval recommended
The changes are focused, regression-tested, and no unresolved review issues remain.
No open issues 🎉
What changed in this PR
Updates the Copilot review-body reader to recognize and count findings under the Unresolved findings: heading.
Changes:
- Adds
unresolved findings:to the recognized labels and finding-list patterns. - Adds regression coverage for all supported finding-list spellings.
| File | Description |
|---|---|
tests/test_pr_review_copilot.py |
Verifies supported finding-list labels produce the expected unthreaded count without notes or unplaced content. |
scripts/reviewers/copilot.json |
Registers the new Copilot findings label and list spelling. |
Review effort: Lite
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3514 +/- ##
========================================
Coverage 81.54% 81.54%
========================================
Files 26 26
Lines 8918 8918
========================================
Hits 7272 7272
Misses 1646 1646
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
## Summary This promotes [#3514](#3514) to `main`. That change teaches the Copilot reader the `Unresolved findings:` label in both its `labels` and `finding_lists`, so a finding listed there is placed and counted against the linked threads. Closes #3513 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Summary
Copilot's review overview now introduces its remaining findings under an
Unresolved findings:label. The Copilot reader inscripts/reviewers/copilot.jsonlisted that spelling in neitherlabelsnorfinding_lists. As a result,pr_review.py statusreported the part as unplaced, and a finding that appeared only in the body was not counted asunthreaded.Changes
unresolved findings:to bothlabelsandfinding_lists, the same wayopen findings remain:is listed. Adding it tolabelsalone, which is what Teach the Copilot Reader the Unresolved Findings Label #3513 proposed, would only silence the notice. The body-only finding would still be missed, becausefinding_listsis what counts listed items against linked threads.unthreadedat 0 where 1 was expected.Verification
uv run --no-project --with-requirements tests/requirements.txt python -m unittest discover -s tests: 3037 tests OK, 7 skipped..husky/pre-commitgates pass: ruff format and lint, mypy, the prose gate, and eol.frontiertier over this diff with zero findings. It is recorded asagent-skillagainstdevelop.Refs #3513, which the promotion pull request closes.
🤖 Generated with Claude Code