Repository navigation
ps2client: Fix fsclient transfer errors, bounds and cleanup - #30
Merged
Merged
Conversation
fjtrujy
force-pushed
the
fix/fsclient-transfer-safety
branch
from
October 31, 2026 14:43
7c077b4 to
7462176
Compare
fjtrujy
force-pushed
the
test/plain-c-infrastructure
branch
from
October 31, 2026 14:45
65c91f8 to
ffb9919
Compare
fjtrujy
force-pushed
the
fix/fsclient-transfer-safety
branch
from
October 31, 2026 14:45
7462176 to
1f6079a
Compare
fjtrujy
force-pushed
the
test/plain-c-infrastructure
branch
from
October 31, 2026 14:46
ffb9919 to
fad5fd3
Compare
fjtrujy
force-pushed
the
fix/fsclient-transfer-safety
branch
2 times, most recently
from
October 31, 2026 15:06
7dc5d29 to
5cfe7f5
Compare
Reject malformed ps2netfs replies and oversized paths, retry partial copies, truncate destinations, and close descriptors on all outcomes. Cover short reads/writes and invalid replies with a native C loopback server. No Python runtime or tests are required.
fjtrujy
force-pushed
the
fix/fsclient-transfer-safety
branch
from
October 31, 2026 15:19
5cfe7f5 to
e2dacba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fsclient_copyto.PS2HOSTNAME=matching and missing copy arguments.tests/fsclient_smoke.c) covering short reads, short writes, and oversized responses.Plain C / compatibility
master(which already includes merged PR ps2client: Migrate Python test tooling to plain C #32).fsclientcommand syntax and ps2netfs protocol are unchanged.Validation
make all check: passed on macOS (five C smoke checks, three new C transfer checks).git diff --check: passed.