Repository navigation
Provision every external review_checks.sh tool; CI check that --list-tools is covered - #2424
Closed
remigiusz-antczak wants to merge 3 commits into
Closed
remigiusz-antczak wants to merge 3 commits into
remigiusz-antczak wants to merge 3 commits into
Conversation
…tools is covered provision_tools.sh now lists all 54 external names that review_checks.sh --list-tools prints (56 table rows). pipx, gem, npm, NuGet, Packagist and Hex rows carry version pins, checked against PyPI, RubyGems, npm, NuGet, Packagist and Hex on 2026-11-18 (21/21 exist); skillspector is pinned to the commit SHA of its v2.13.6 tag. uv is a brew row so skillspector installs in one owner run; npm rows are gated on node. A cmd row whose toolchain (dotnet, composer, mix) is absent prints BLOCKED. Cask rows (codeql) install through a macOS-only brew install --cask call and print BLOCKED on other hosts. opengrep (no Homebrew formula, unpinned upstream installer) prints a BLOCKED line with its reason and no install line. --print installs each brew formula, pipx package, gem and npm/other row on its own and prints FAILED <name> on failure, so one bad name does not stop the rest. The gem line honors DCR_USER_BIN and falls back to plain gem when brew is absent; sobelow installs with --force. The installed-tool probe and the review_checks.sh PATH include ~/.dotnet/tools, composer vendor/bin and ~/.mix/escripts when they exist, and review_checks.sh no longer overwrites the global d. New tests, all registered in scripts/ci-tests.d: test-provision-covers-list-tools.sh (every external name has a row or a reasoned no-install entry, and every ALIAS/NOINSTALL key is in --list-tools), test-provision-toolchain-dirs.sh, test-provision-failed-names.sh (stub installs exit 1; asserts FAILED <name> and the no-brew note) and test-provision-cask-blocked.sh. The dry-run test asserts named tools instead of counts. size-budget-raise: .claude/skills/deep-code-review/references/tool-hub.md 63131→64183 the pin provenance note and the opengrep blocker row; the base file was already at budget Tests: 76/76 (failed-names 5, provision-tools 61, covers-list-tools 1, toolchain-dirs 8, cask-blocked 1; test_audit_skills OK), run under /bin/bash 3.2; bash -n clean Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B4dfwdDQiF3RQMUqYBqefc
Keep the merged tool-hub.md size budget at its real merged size (64982) and record the raise in the changelog fragment. No-Mechanism-Reason: merge resolution of one size-budget row; no skill prose changed beyond the auto-merge Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B4dfwdDQiF3RQMUqYBqefc
The fuzz row added on main runs `go test -fuzz`, so its binary is go, which provision_tools.sh already installs. Without the alias the coverage check failed the per-PR leg after the merge from main. Tests: 1/1 (provision coverage check: 55 external names covered) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B4dfwdDQiF3RQMUqYBqefc
Collaborator
Author
|
Superseded by #2425 (one squashed commit on current main, plus the fuzz→go alias in the provision coverage check). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
provision_tools.shnow has a row for every external tool thatreview_checks.sh --list-toolsprints, and a CI test fails when a new tool is added to the hub without one.BLOCKED <name> (<reason>)instead of an install line that would fail: missing toolchain (dotnet, composer, mix), casks off macOS, and opengrep (no Homebrew formula, unpinned upstream installer).--printinstalls each row on its own and printsFAILED <name>, so one bad name no longer stops the rest.~/.dotnet/tools, composervendor/binand~/.mix/escripts.Tests: 76/76 across five provision test scripts (all registered in
scripts/ci-tests.d),test_audit_skills.pyrecall 89/89,bash -nclean. Thetool-hub.mdbudget row rises 63131→64183 with the marker in the commit message.🤖 Generated with Claude Code
https://claude.ai/code/session_01B4dfwdDQiF3RQMUqYBqefc