Skip to content

Provision every external review_checks.sh tool; CI check that --list-tools is covered - #2424

Closed
remigiusz-antczak wants to merge 3 commits into
mainfrom
provision-all-tools-1118
Closed

remigiusz-antczak wants to merge 3 commits into
mainfrom
provision-all-tools-1118

Conversation

@remigiusz-antczak

Copy link
Copy Markdown
Collaborator

provision_tools.sh now has a row for every external tool that review_checks.sh --list-tools prints, and a CI test fails when a new tool is added to the hub without one.

  • 54 external names covered (56 table rows). pipx, gem, npm, NuGet, Packagist and Hex rows carry version pins, checked on 2026-11-18 (21/21 exist); skillspector is pinned to a tag's commit SHA.
  • Rows that cannot install on this host print BLOCKED <name> (<reason>) instead of an install line that would fail: missing toolchain (dotnet, composer, mix), casks off macOS, and opengrep (no Homebrew formula, unpinned upstream installer).
  • --print installs each row on its own and prints FAILED <name>, so one bad name no longer stops the rest.
  • The installed-tool probe and the hub PATH also look in ~/.dotnet/tools, composer vendor/bin and ~/.mix/escripts.

Tests: 76/76 across five provision test scripts (all registered in scripts/ci-tests.d), test_audit_skills.py recall 89/89, bash -n clean. The tool-hub.md budget row rises 63131→64183 with the marker in the commit message.

🤖 Generated with Claude Code

https://claude.ai/code/session_01B4dfwdDQiF3RQMUqYBqefc

remigiusz-antczak and others added 3 commits November 18, 2026 10:36
…tools is covered

provision_tools.sh now lists all 54 external names that review_checks.sh --list-tools prints (56 table
rows). pipx, gem, npm, NuGet, Packagist and Hex rows carry version pins, checked against PyPI,
RubyGems, npm, NuGet, Packagist and Hex on 2026-11-18 (21/21 exist); skillspector is pinned to the
commit SHA of its v2.13.6 tag. uv is a brew row so skillspector installs in one owner run; npm rows are
gated on node. A cmd row whose toolchain (dotnet, composer, mix) is absent prints BLOCKED. Cask rows
(codeql) install through a macOS-only brew install --cask call and print BLOCKED on other hosts.
opengrep (no Homebrew formula, unpinned upstream installer) prints a BLOCKED line with its reason and no
install line. --print installs each brew formula, pipx package, gem and npm/other row on its own and
prints FAILED <name> on failure, so one bad name does not stop the rest. The gem line honors
DCR_USER_BIN and falls back to plain gem when brew is absent; sobelow installs with --force. The
installed-tool probe and the review_checks.sh PATH include ~/.dotnet/tools, composer vendor/bin and
~/.mix/escripts when they exist, and review_checks.sh no longer overwrites the global d.

New tests, all registered in scripts/ci-tests.d: test-provision-covers-list-tools.sh (every external
name has a row or a reasoned no-install entry, and every ALIAS/NOINSTALL key is in --list-tools),
test-provision-toolchain-dirs.sh, test-provision-failed-names.sh (stub installs exit 1; asserts
FAILED <name> and the no-brew note) and test-provision-cask-blocked.sh. The dry-run test asserts named
tools instead of counts.

size-budget-raise: .claude/skills/deep-code-review/references/tool-hub.md 63131→64183 the pin provenance note and the opengrep blocker row; the base file was already at budget

Tests: 76/76 (failed-names 5, provision-tools 61, covers-list-tools 1, toolchain-dirs 8, cask-blocked 1; test_audit_skills OK), run under /bin/bash 3.2; bash -n clean

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B4dfwdDQiF3RQMUqYBqefc
Keep the merged tool-hub.md size budget at its real merged size (64982) and record the raise in the changelog fragment.

No-Mechanism-Reason: merge resolution of one size-budget row; no skill prose changed beyond the auto-merge
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B4dfwdDQiF3RQMUqYBqefc
The fuzz row added on main runs `go test -fuzz`, so its binary is go, which
provision_tools.sh already installs. Without the alias the coverage check
failed the per-PR leg after the merge from main.

Tests: 1/1 (provision coverage check: 55 external names covered)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B4dfwdDQiF3RQMUqYBqefc
@remigiusz-antczak

Copy link
Copy Markdown
Collaborator Author

Superseded by #2425 (one squashed commit on current main, plus the fuzz→go alias in the provision coverage check).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant