Skip to content

Fix issue with shallowEquals incorrectly returning too early #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ice1080 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix issue with shallowEquals incorrectly returning too early #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ade7d0
Fix issue with incorrectly returning too early
ice1080 May 11, 2026
1f2b8ed
Merge branch 'main' of github.com:playcanvas/react
ice1080 Sep 10, 2026
1c260ab
chore: add changeset for shallowEquals fix
ice1080 Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/whole-paws-sort.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@playcanvas/react": patch
---

Fix `shallowEquals` incorrectly returning early before checking all properties.
4 changes: 2 additions & 2 deletions packages/lib/src/utils/compare.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ export const shallowEquals = (objA: Record<string, unknown>, objB: Record<string
const propA = objA[key];
const propB = objB[key];
// If the object has an equality operator, use this
if (hasEqualsMethod(propA)) {
return propA.equals(propB);
if (hasEqualsMethod(propA) && !propA.equals(propB)) {
return false;
} else if (propA !== propB) {
return false;
}
Expand Down