Fix issue with shallowEquals incorrectly returning too early - #344
Open
ice1080 wants to merge 3 commits into
Open
Fix issue with shallowEquals incorrectly returning too early#344ice1080 wants to merge 3 commits into
ice1080 wants to merge 3 commits into
Conversation
# Conflicts: # packages/lib/src/utils/compare.tsx
🦋 Changeset detectedLatest commit: 1c260ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shallowEquals can return true after comparing a single property with an equals method, skipping later properties and preventing expected rerenders. Preserve the existing change to return false for unequal properties and continue checking the remaining keys.
Replaces #319 to move the contribution off the fork’s main branch. Includes the merge of current upstream main and resolves the formatting conflict in compare.tsx.
Validation: git diff --check passed; the diff against upstream contains only the original comparison change. Tests were not run because pnpm is unavailable in the local environment.
As noted in #319, this is a small interim change related to #298.